Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Unhelpful message abbrevation for E0277 #39802

Closed
Xion opened this issue Feb 14, 2017 · 1 comment
Closed

Unhelpful message abbrevation for E0277 #39802

Xion opened this issue Feb 14, 2017 · 1 comment
Labels
A-diagnostics Area: Messages for errors, warnings, and lints E-easy Call for participation: Easy difficulty. Experience needed to fix: Not much. Good first issue. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.

Comments

@Xion
Copy link

Xion commented Feb 14, 2017

A minor error message snafu:

error[E0277]: the trait bound `std::io::Error: std::convert::From<hyper::Error>` is not satisfied
   (code sample elided for brevity)
    = help: the following implementations were found:
              <std::io::Error as std::convert::From<std::ffi::NulError>>
              <std::io::Error as std::convert::From<std::io::IntoInnerError<W>>>
              <std::io::Error as std::convert::From<std::io::ErrorKind>>
              <std::io::Error as std::convert::From<slog::ser::Error>>
            and 1 others
    = note: required by `std::convert::From::from`
    = note: this error originates in a macro outside of the current crate

Notice the and 1 others line. It doesn't abbreviate anything; the compiler could've inserted the one missing impl and take the same amount of screen space.

@brson brson added E-easy Call for participation: Easy difficulty. Experience needed to fix: Not much. Good first issue. I-papercut A-diagnostics Area: Messages for errors, warnings, and lints T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Feb 14, 2017
@brson
Copy link
Contributor

brson commented Feb 14, 2017

Just detect the case where there are 5 choices and print them all.

frewsxcv added a commit to frewsxcv/rust that referenced this issue Feb 15, 2017
…jonathandturner

Show five traits implementation in help when there are exactly five

Fixes rust-lang#39802
frewsxcv added a commit to frewsxcv/rust that referenced this issue Feb 15, 2017
…jonathandturner

Show five traits implementation in help when there are exactly five

Fixes rust-lang#39802
frewsxcv added a commit to frewsxcv/rust that referenced this issue Feb 16, 2017
…jonathandturner

Show five traits implementation in help when there are exactly five

Fixes rust-lang#39802
frewsxcv added a commit to frewsxcv/rust that referenced this issue Feb 16, 2017
…jonathandturner

Show five traits implementation in help when there are exactly five

Fixes rust-lang#39802
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
A-diagnostics Area: Messages for errors, warnings, and lints E-easy Call for participation: Easy difficulty. Experience needed to fix: Not much. Good first issue. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Development

No branches or pull requests

2 participants