Skip to content

Documentation for LocalKey could be better worded #39841

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom
Closed
ghost opened this issue Feb 15, 2017 · 1 comment
Closed

Documentation for LocalKey could be better worded #39841

ghost opened this issue Feb 15, 2017 · 1 comment

Comments

@ghost
Copy link

ghost commented Feb 15, 2017

Source: https://doc.rust-lang.org/std/thread/struct.LocalKey.html

"Initialization is dynamically performed on the first call to with() within a thread, and values support destructors which will be run when a thread exits."

It's unclear what's going on with destructors in this sentence.
The truth is: values that implement Drop will probably (on a best-effort basis) get dropped when a thread exits.
@GuillaumeGomez
Copy link
Member

Any contribution is very welcome. Don't hesitate to give it a try! :)

@ghost ghost mentioned this issue Feb 15, 2017
Merged
frewsxcv added a commit to frewsxcv/rust that referenced this issue Feb 17, 2017
@frewsxcv
Rollup merge of rust-lang#39862 - stjepang:fix-wording-localkey, r=Gu…
f03656a 
…illaumeGomez

Fix wording in LocalKey documentation

Fixes rust-lang#39841

r? @GuillaumeGomez
frewsxcv added a commit to frewsxcv/rust that referenced this issue Feb 17, 2017
@frewsxcv
Rollup merge of rust-lang#39862 - stjepang:fix-wording-localkey, r=Gu…
b6d6f6d 
…illaumeGomez

Fix wording in LocalKey documentation

Fixes rust-lang#39841

r? @GuillaumeGomez
GuillaumeGomez added a commit to GuillaumeGomez/rust that referenced this issue Feb 17, 2017
@GuillaumeGomez
Rollup merge of rust-lang#39862 - stjepang:fix-wording-localkey, r=Gu…
2634721 
…illaumeGomez

Fix wording in LocalKey documentation

Fixes rust-lang#39841

r? @GuillaumeGomez
GuillaumeGomez added a commit to GuillaumeGomez/rust that referenced this issue Feb 18, 2017
@GuillaumeGomez
Rollup merge of rust-lang#39862 - stjepang:fix-wording-localkey, r=Gu…
e4c285d 
…illaumeGomez

Fix wording in LocalKey documentation

Fixes rust-lang#39841

r? @GuillaumeGomez
# for free to join this conversation on GitHub. Already have an account? # to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@steveklabnik @GuillaumeGomez