-
Notifications
You must be signed in to change notification settings - Fork 13.4k
Tracking issue for addition of eprint/eprintln macros #40528
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
Comments
|
Sure yeah, want to resubmit that as a new PR? |
Is it actually necessary to resubmit? Couldn't you just reopen the existing one? |
Let's stick with a new PR, easier on bors in general |
@zackw when you make your new PR, mind also adding an entry to https://github.com/rust-lang/rust/tree/master/src/doc/unstable-book ? It doesn't need to actually have docs in it. Check out any of the chapters for the little template. |
Add `eprint!` and `eprintln!` macros to the prelude. These are exactly the same as `print!` and `println!` except that they write to stderr instead of stdout. Issues rust-lang#39228 and rust-lang#40528; previous PR rust-lang#39229; accepted RFC rust-lang/rfcs#1869; proposed revision to The Book rust-lang/book#615. I have _not_ revised this any since the original submission; I will do that later this week. I wanted to get this PR in place since it's been quite a while since the RFC was merged. Known outstanding review comments: * [x] @steveklabnik requested a new chapter for the unstable version of The Book -- please see if the proposed revisions to the second edition cover it. * [x] @nodakai asked if it were possible to merge the internal methods `_print` and `_eprint` - not completely, since they both refer to different internal globals which we don't want to expose, but I will see if some duplication can be factored out. Please let me know if I missed anything.
Add `eprint!` and `eprintln!` macros to the prelude. These are exactly the same as `print!` and `println!` except that they write to stderr instead of stdout. Issues rust-lang#39228 and rust-lang#40528; previous PR rust-lang#39229; accepted RFC rust-lang/rfcs#1869; proposed revision to The Book rust-lang/book#615. I have _not_ revised this any since the original submission; I will do that later this week. I wanted to get this PR in place since it's been quite a while since the RFC was merged. Known outstanding review comments: * [x] @steveklabnik requested a new chapter for the unstable version of The Book -- please see if the proposed revisions to the second edition cover it. * [x] @nodakai asked if it were possible to merge the internal methods `_print` and `_eprint` - not completely, since they both refer to different internal globals which we don't want to expose, but I will see if some duplication can be factored out. Please let me know if I missed anything.
I think this was stabilized, though I don't see any discussion here. @alexcrichton Any idea where that happened? Closing anyway.. |
For the record, the code change was merged in #41192. |
Ah yes macros IIRC can't be stabilized in the same way as other items, so we added these as insta-stable. |
Tracking issue for for rust-lang/rfcs#1869
@zackw would you be interested in sending a PR?
The text was updated successfully, but these errors were encountered: