Skip to content

Tracking issue for addition of eprint/eprintln macros #40528

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Closed
alexcrichton opened this issue Mar 14, 2017 · 8 comments
Closed

Tracking issue for addition of eprint/eprintln macros #40528

alexcrichton opened this issue Mar 14, 2017 · 8 comments
Labels
B-RFC-approved Blocker: Approved by a merged RFC but not yet implemented. C-tracking-issue Category: An issue tracking the progress of sth. like the implementation of an RFC T-libs-api Relevant to the library API team, which will review and decide on the PR/issue.

Comments

@alexcrichton
Copy link
Member

Tracking issue for for rust-lang/rfcs#1869

@zackw would you be interested in sending a PR?

@alexcrichton alexcrichton added B-RFC-approved Blocker: Approved by a merged RFC but not yet implemented. T-libs-api Relevant to the library API team, which will review and decide on the PR/issue. labels Mar 14, 2017
@zackw
Copy link
Contributor

zackw commented Mar 14, 2017

>.> Reopen #39229 and proceed from there?

@alexcrichton
Copy link
Member Author

Sure yeah, want to resubmit that as a new PR?

@zackw
Copy link
Contributor

zackw commented Mar 14, 2017

Is it actually necessary to resubmit? Couldn't you just reopen the existing one?

@alexcrichton
Copy link
Member Author

Let's stick with a new PR, easier on bors in general

@steveklabnik
Copy link
Member

@zackw when you make your new PR, mind also adding an entry to https://github.com/rust-lang/rust/tree/master/src/doc/unstable-book ? It doesn't need to actually have docs in it. Check out any of the chapters for the little template.

frewsxcv added a commit to frewsxcv/rust that referenced this issue May 11, 2017
Add `eprint!` and `eprintln!` macros to the prelude.

These are exactly the same as `print!` and `println!` except that they write to stderr instead of stdout.  Issues rust-lang#39228 and rust-lang#40528; previous PR rust-lang#39229; accepted RFC rust-lang/rfcs#1869; proposed revision to The Book rust-lang/book#615.

I have _not_ revised this any since the original submission; I will do that later this week.  I wanted to get this PR in place since it's been quite a while since the RFC was merged.

Known outstanding review comments:

* [x] @steveklabnik requested a new chapter for the unstable version of The Book -- please see if the proposed revisions to the second edition cover it.
* [x] @nodakai asked if it were possible to merge the internal methods `_print` and `_eprint` - not completely, since they both refer to different internal globals which we don't want to expose, but I will see if some duplication can be factored out.

Please let me know if I missed anything.
frewsxcv added a commit to frewsxcv/rust that referenced this issue May 11, 2017
Add `eprint!` and `eprintln!` macros to the prelude.

These are exactly the same as `print!` and `println!` except that they write to stderr instead of stdout.  Issues rust-lang#39228 and rust-lang#40528; previous PR rust-lang#39229; accepted RFC rust-lang/rfcs#1869; proposed revision to The Book rust-lang/book#615.

I have _not_ revised this any since the original submission; I will do that later this week.  I wanted to get this PR in place since it's been quite a while since the RFC was merged.

Known outstanding review comments:

* [x] @steveklabnik requested a new chapter for the unstable version of The Book -- please see if the proposed revisions to the second edition cover it.
* [x] @nodakai asked if it were possible to merge the internal methods `_print` and `_eprint` - not completely, since they both refer to different internal globals which we don't want to expose, but I will see if some duplication can be factored out.

Please let me know if I missed anything.
@Mark-Simulacrum Mark-Simulacrum added the C-tracking-issue Category: An issue tracking the progress of sth. like the implementation of an RFC label Jul 27, 2017
@Mark-Simulacrum
Copy link
Member

I think this was stabilized, though I don't see any discussion here. @alexcrichton Any idea where that happened? Closing anyway..

@zackw
Copy link
Contributor

zackw commented Jul 27, 2017

For the record, the code change was merged in #41192.

@alexcrichton
Copy link
Member Author

Ah yes macros IIRC can't be stabilized in the same way as other items, so we added these as insta-stable.

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
B-RFC-approved Blocker: Approved by a merged RFC but not yet implemented. C-tracking-issue Category: An issue tracking the progress of sth. like the implementation of an RFC T-libs-api Relevant to the library API team, which will review and decide on the PR/issue.
Projects
None yet
Development

No branches or pull requests

4 participants