Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Tracking issue for the FromUtf8Error::as_bytes #40895

Closed
3Hren opened this issue Mar 29, 2017 · 9 comments
Closed

Tracking issue for the FromUtf8Error::as_bytes #40895

3Hren opened this issue Mar 29, 2017 · 9 comments
Labels
B-unstable Blocker: Implemented in the nightly compiler and unstable. C-tracking-issue Category: An issue tracking the progress of sth. like the implementation of an RFC final-comment-period In the final comment period and will be merged soon unless new substantive objections are raised. T-libs-api Relevant to the library API team, which will review and decide on the PR/issue.

Comments

@3Hren
Copy link
Contributor

3Hren commented Mar 29, 2017

Added in #40290 under the from_utf8_error_as_bytes feature flag.
@aturon aturon added B-unstable Blocker: Implemented in the nightly compiler and unstable. T-libs-api Relevant to the library API team, which will review and decide on the PR/issue. labels Mar 29, 2017
@Mark-Simulacrum Mark-Simulacrum added the C-tracking-issue Category: An issue tracking the progress of sth. like the implementation of an RFC label Jul 22, 2017
@Mark-Simulacrum
Copy link
Member

@rust-lang/libs Nominating for stabilization. Seems like a good addition with no (known) blockers.

@sfackler
Copy link
Member

@rfcbot fcp merge

@rfcbot rfcbot added the proposed-final-comment-period Proposed to merge/close by relevant subteam, see T-<team> label. Will enter FCP once signed off. label Jan 18, 2018
@rfcbot
Copy link

rfcbot commented Jan 18, 2018 •
edited by Kimundi
Loading

Team member @sfackler has proposed to merge this. The next step is review by the rest of the tagged teams:

No concerns currently listed.

Once these reviewers reach consensus, this will enter its final comment period. If you spot a major issue that hasn't been raised at any point in this process, please speak up!

See this document for info about what commands tagged team members can give me.

@rfcbot
Copy link

rfcbot commented Jan 23, 2018

🔔 This is now entering its final comment period, as per the review above. 🔔

@rfcbot rfcbot added final-comment-period In the final comment period and will be merged soon unless new substantive objections are raised. and removed proposed-final-comment-period Proposed to merge/close by relevant subteam, see T-<team> label. Will enter FCP once signed off. labels Jan 23, 2018
@rfcbot
Copy link

rfcbot commented Jan 23, 2018

🔔 This is now entering its final comment period, as per the review above. 🔔

1 similar comment
@rfcbot
Copy link

rfcbot commented Jan 23, 2018

🔔 This is now entering its final comment period, as per the review above. 🔔

@rfcbot
Copy link

rfcbot commented Feb 2, 2018

The final comment period is now complete.

varkor added a commit to varkor/rust that referenced this issue Mar 17, 2018
@varkor
Stabilise FromUtf8Error::as_bytes
b57ea56 
Closes rust-lang#40895.
@varkor varkor mentioned this issue Mar 17, 2018
Merged
@ErichDonGubler
Copy link
Contributor

How does one contribute after the FCP has gone through for stabilization? I'm not familiar with it and want to learn. :) Is that something the community contributes, or do we have a big stabilization PR like this one?

@SimonSapin
Copy link
Contributor

Both are possible. In this case I see that #49121 has already been submitted.

alexcrichton added a commit to alexcrichton/rust that referenced this issue Mar 23, 2018
@alexcrichton
Rollup merge of rust-lang#49121 - varkor:stabilise-from_utf8_error_as…
59b5887 
…_bytes, r=bluss

Stabilise FromUtf8Error::as_bytes

Closes rust-lang#40895.
kennytm added a commit to kennytm/rust that referenced this issue Mar 24, 2018
@kennytm
Rollup merge of rust-lang#49121 - varkor:stabilise-from_utf8_error_as…
cd9981c 
…_bytes, r=bluss

Stabilise FromUtf8Error::as_bytes

Closes rust-lang#40895.
kennytm added a commit to kennytm/rust that referenced this issue Mar 24, 2018
@kennytm
Rollup merge of rust-lang#49121 - varkor:stabilise-from_utf8_error_as…
adb7984 
…_bytes, r=bluss

Stabilise FromUtf8Error::as_bytes

Closes rust-lang#40895.
# for free to join this conversation on GitHub. Already have an account? # to comment
Assignees
No one assigned
Labels
B-unstable Blocker: Implemented in the nightly compiler and unstable. C-tracking-issue Category: An issue tracking the progress of sth. like the implementation of an RFC final-comment-period In the final comment period and will be merged soon unless new substantive objections are raised. T-libs-api Relevant to the library API team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
8 participants
@alexcrichton @SimonSapin @ErichDonGubler @aturon @3Hren @sfackler @Mark-Simulacrum @rfcbot