Skip to content

Vector impls don't work well with explicit self #4132

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Closed
brson opened this issue Dec 7, 2012 · 1 comment
Closed

Vector impls don't work well with explicit self #4132

brson opened this issue Dec 7, 2012 · 1 comment
Assignees
Milestone

Comments

@brson
Copy link
Contributor

brson commented Dec 7, 2012

This doesn't work because method.rs needs to do 2 auto refs. Can't convert BaseIter to explicit self without.

// Testing that method lookup automatically both borrows vectors to slices
// and also references them to create the &self pointer

trait MyIter {
    pure fn test_imm(&self);
    pure fn test_const(&const self);
}

impl &[int]: MyIter {
    pure fn test_imm(&self) { assert self[0] == 1 }
    pure fn test_const(&const self) { assert self[0] == 1 }
}

impl &str: MyIter {
    pure fn test_imm(&self) { assert *self == "test" }
    pure fn test_const(&const self) { assert *self == "test" }
}

fn main() {
    // NB: Associativity of ~, etc. in this context is surprising. These must be parenthesized

    ([1]).test_imm();
    (~[1]).test_imm();
    (@[1]).test_imm();
    (&[1]).test_imm();
    ("test").test_imm();
    (~"test").test_imm();
    (@"test").test_imm();
    (&"test").test_imm();

    ([1]).test_const();
    (~[1]).test_const();
    (@[1]).test_const();
    (&[1]).test_const();
    ("test").test_const();
    (~"test").test_const();
    (@"test").test_const();
    (&"test").test_const();

    // NB: We don't do this double autoreffing for &mut self because that would
    // allow creating a mutable pointer to a temporary, which would be a source
    // of confusion
}
@brson
Copy link
Contributor Author

brson commented Dec 10, 2012

Fixed

@brson brson closed this as completed Dec 10, 2012
RalfJung pushed a commit to RalfJung/rust that referenced this issue Jan 19, 2025
…e-changes

Switched FreeBSD to pthread_setname_np
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant