Skip to content

Tracking issue for struct_field_attributes #41681

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom
Closed
3 of 4 tasks
mbrubeck opened this issue May 1, 2017 · 13 comments
Closed
3 of 4 tasks

Tracking issue for struct_field_attributes #41681

mbrubeck opened this issue May 1, 2017 · 13 comments
Labels
B-unstable Blocker: Implemented in the nightly compiler and unstable. C-tracking-issue Category: An issue tracking the progress of sth. like the implementation of an RFC E-easy Call for participation: Easy difficulty. Experience needed to fix: Not much. Good first issue. E-mentor Call for participation: This issue has a mentor. Use #t-compiler/help on Zulip for discussion. final-comment-period In the final comment period and will be merged soon unless new substantive objections are raised. T-lang Relevant to the language team, which will review and decide on the PR/issue.

Comments

@mbrubeck
Copy link
Contributor

mbrubeck commented May 1, 2017 •
edited by nikomatsakis
Loading

Status
@mbrubeck mbrubeck added B-unstable Blocker: Implemented in the nightly compiler and unstable. T-lang Relevant to the language team, which will review and decide on the PR/issue. labels May 1, 2017
@mbrubeck mbrubeck mentioned this issue May 1, 2017
Merged
@Ms2ger Ms2ger mentioned this issue May 1, 2017
Closed
99 tasks
@blt blt mentioned this issue May 13, 2017
Open
2 tasks
@SergioBenitez
Copy link
Contributor

This has been around for a while (since Jan. 2017, ~4 months) and appears to be quite solid in my testing. Is there a reason to not move this into FCP for stabilization? @brson

@SergioBenitez SergioBenitez mentioned this issue May 19, 2017
Closed
11 tasks
@brson
Copy link
Contributor

brson commented May 22, 2017

cc @rust-lang/lang Ready for stabilization?

@withoutboats
Copy link
Contributor

@rfcbot fcp merge

@rfcbot
Copy link
Collaborator

rfcbot commented May 23, 2017 •
edited by pnkfelix
Loading

Team member @withoutboats has proposed to merge this. The next step is review by the rest of the tagged teams:

No concerns currently listed.

Once these reviewers reach consensus, this will enter its final comment period. If you spot a major issue that hasn't been raised at any point in this process, please speak up!

See this document for info about what commands tagged team members can give me.

@rfcbot
Copy link
Collaborator

rfcbot commented Jun 3, 2017

🔔 This is now entering its final comment period, as per the review above. 🔔

@rfcbot rfcbot added the final-comment-period In the final comment period and will be merged soon unless new substantive objections are raised. label Jun 3, 2017
@rfcbot
Copy link
Collaborator

rfcbot commented Jun 13, 2017

The final comment period is now complete.

@nikomatsakis
Copy link
Contributor

Now that we've decided to stabilize this, we need someone to prepare a stabilization PR! There are some general instructions for how to do this on forge. Based on a quick run of rg struct_field_attributes, this should be a pretty straight-forward case! Just have to remove some of the feature-gate tests from libsyntax and a few other places.

The other major thing we need before we can stabilize is documentation PRs.

@nikomatsakis nikomatsakis added E-mentor Call for participation: This issue has a mentor. Use #t-compiler/help on Zulip for discussion. E-easy Call for participation: Easy difficulty. Experience needed to fix: Not much. Good first issue. labels Jun 13, 2017
@nikomatsakis
Copy link
Contributor

Marking as E-mentor. The instructions are here.

@tirr-c
Copy link
Contributor

tirr-c commented Jun 13, 2017

I want to work on removing the feature gate.

@tirr-c tirr-c mentioned this issue Jun 14, 2017
Merged
@nikomatsakis
Copy link
Contributor

@VBChunguk nice job :)

frewsxcv added a commit to frewsxcv/rust that referenced this issue Jun 16, 2017
@frewsxcv
Rollup merge of rust-lang#42656 - VBChunguk:struct-field-attributes, …
999f3ad 
…r=nikomatsakis

Remove struct_field_attributes feature gate

Part of rust-lang#41681. ~This PR only removes the feature gate; this *does not* update any documentations.~ This PR removes the feature gate and the corresponding chapter of the Unstable Book.

I'm not very sure about the changes I made though... Just followed the stabilization guideline.

r? @nikomatsakis
@nikomatsakis
Copy link
Contributor

Did we actually write stable documentation here? Skimming the threads I didn't see any PRs...?

@Mark-Simulacrum Mark-Simulacrum added the C-tracking-issue Category: An issue tracking the progress of sth. like the implementation of an RFC label Jul 22, 2017
@theduke
Copy link
Contributor

theduke commented Aug 31, 2017

This was stabilized with 1.20 as far as I can tell?

hcpl added a commit to hcpl/serde_mtproto that referenced this issue Sep 5, 2017
@hcpl
Add commented tests regarding extprim
8ccf1a5 
For now let them be commented until bumping minimal Rust version to 1.20
because of the struct field attributes feature
(rust-lang/rust#41681).
@cramertj
Copy link
Member

Stabilized-- closing. LMK if there are any outstanding items here and I'll reopen.

# for free to join this conversation on GitHub. Already have an account? # to comment
Assignees
No one assigned
Labels
B-unstable Blocker: Implemented in the nightly compiler and unstable. C-tracking-issue Category: An issue tracking the progress of sth. like the implementation of an RFC E-easy Call for participation: Easy difficulty. Experience needed to fix: Not much. Good first issue. E-mentor Call for participation: This issue has a mentor. Use #t-compiler/help on Zulip for discussion. final-comment-period In the final comment period and will be merged soon unless new substantive objections are raised. T-lang Relevant to the language team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests