Skip to content

Rust 1.18 regression, crates-io-cli 2.0.1, no such file or directory #41797

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom
Closed
brson opened this issue May 6, 2017 · 14 comments · Fixed by rust-lang/cargo#4046
Closed

Rust 1.18 regression, crates-io-cli 2.0.1, no such file or directory #41797

brson opened this issue May 6, 2017 · 14 comments · Fixed by rust-lang/cargo#4046
Labels
P-high High priority regression-from-stable-to-beta Performance or correctness regression from stable to beta. T-cargo Relevant to the cargo team, which will review and decide on the PR/issue.

Comments

@brson
Copy link
Contributor

brson commented May 6, 2017

https://github.com/Byron/crates-io-cli-rs

brian@ip-10-145-43-250:~/dev/crates-io-cli-rs⟫ git log -1
commit ff374c57064414aaca7d1335d36ab1cb015a8606
Author: Niko Hellwig <nhellwig@thoughtworks.com>
Date:   Tue Feb 7 17:26:47 2017 +0100

    (imp): "Implemented CTRL-C to exit crates search command"

brian@ip-10-145-43-250:/mnt2/dev⟫ rustc +beta -Vv
rustc 1.18.0-beta.1 (4dce67253 2017-04-25)
binary: rustc
commit-hash: 4dce67253d67785c74c8d270c38d774edd0deed8
commit-date: 2017-04-25
host: x86_64-unknown-linux-gnu
release: 1.18.0-beta.1
LLVM version: 3.9

   Compiling libz-sys v1.0.12
   Compiling mio v0.6.2
   Compiling cmake v0.1.20
   Compiling libgit2-sys v0.6.6
   Compiling tokio-core v0.1.3
   Compiling libssh2-sys v0.2.5
   Compiling curl v0.4.3
   Compiling tokio-curl v0.1.8
   Compiling git2 v0.6.3
   Compiling crates-index-diff v3.0.0
   Compiling crates-io-cli v2.0.0 (file:///mnt2/dev/crates-io-cli-rs)
error: couldn't read "src/bin/krates.rs": No such file or directory (os error 2)

error: couldn't read "src/bin/crates.rs": No such file or directory (os error 2)

error: Could not compile `crates-io-cli`.
Build failed, waiting for other jobs to finish...
error: build failed

cc @Byron @alexcrichton

Maybe related to #41794
@brson brson added the regression-from-stable-to-beta Performance or correctness regression from stable to beta. label May 6, 2017
@brson
Copy link
Contributor Author

brson commented May 6, 2017

Also affects eclectica-0.0.9 cc @markelog

@brson
Copy link
Contributor Author

brson commented May 7, 2017

Also igo-0.2.1 cc @yshryk

@brson
Copy link
Contributor Author

brson commented May 7, 2017

Also isbfc-0.0.1 cc @ids1024

@brson brson mentioned this issue May 7, 2017
Closed
@brson
Copy link
Contributor Author

brson commented May 7, 2017

Also cargo-update-0.8.0 (#41794) cc @nabijaczleweli

@brson
Copy link
Contributor Author

brson commented May 7, 2017

Also https://github.com/zargony/advent-of-code-2015 cc @zargony

@Mark-Simulacrum
Copy link
Member

Rust commit: 910c481 (looks like bug isn't here)

Cargo commit: rust-lang/cargo@c416fb6, which seems correct. #40955 is the stable/nightly issue, #41166 is the PR updating cargo submodule to fix this, which probably needs to be backported to beta. I'm uncertain, though.

@alexcrichton
Copy link
Member

cc @jmatraszek, sorry to tag you in again, but if you could help take a look at this that'd be great! If not no worries!

@jmatraszek
Copy link

jmatraszek commented May 12, 2017 •
edited
Loading

Hi @alexcrichton, this definitely looks related to my changes in cargo.

I've investigated crates-io-cli-rs and this crate defines two bins (crates and krates). I suppose they were intended to be aliases and this was possible because of a original "bug" in cargo (falling back to main.rs). I have mixed feelings about this. I would say that cargo should fail here instead of falling back to main.rs, but I suppose we cannot do that because of backwards compatibility. Right?

igo fails because it defines bin targets inside src directly, instead of src/bin. Seems easy and I'll try to fix this today in the evening.

@brson Could you please provide me with the cargo's output for the other crates (especially eclectica)? That would be great.

@alexcrichton
Copy link
Member

Ah yeah for now our priority is to stem the breakage, and afterwards we can evaluate warnings cycles/etc to push further towards the desired behavior here.

Thanks for investigating this @jmatraszek!

@jmatraszek
Copy link

I think I have fixed this, just need one more day to do some more testing and I should open a pull request tomorrow.

@jmatraszek jmatraszek mentioned this issue May 14, 2017
Merged
@jmatraszek
Copy link

Added a proposed fix.

bors added a commit to rust-lang/cargo that referenced this issue May 15, 2017
@bors
Auto merge of #4046 - jmatraszek:fix_rust_41797, r=alexcrichton
d5bfd58 
Change inferring bin's name logic

Should fix rust-lang/rust#41797.
@alexcrichton
Copy link
Member

Ah we should actually leave this open to track the inclusion into beta, I'll close when all the backports are done.

@alexcrichton alexcrichton reopened this May 16, 2017
alexcrichton added a commit to alexcrichton/rust that referenced this issue May 16, 2017
@alexcrichton
Update cargo submodule
c9f616c 
This pulls in a fix for rust-lang#41797 to the master branch, I'll send a separate PR for
the beta branch.
@alexcrichton alexcrichton mentioned this issue May 16, 2017
Merged
alexcrichton added a commit to alexcrichton/rust that referenced this issue May 16, 2017
@alexcrichton
[beta] Update cargo submodule
65ba0c1 
This pulls in a fix for rust-lang#41797 to the beta branch, and the relevant PR for Cargo
is rust-lang/cargo#4046

Closes rust-lang#41797
@alexcrichton alexcrichton mentioned this issue May 16, 2017
Merged
@alexcrichton
Copy link
Member

Ok I've updated Cargo's beta, updated our master branch and updated our beta branch, this'll get closed when those start merging.

Thanks again for fixing this @jmatraszek!

Mark-Simulacrum added a commit to Mark-Simulacrum/rust that referenced this issue May 16, 2017
@Mark-Simulacrum
Rollup merge of rust-lang#42039 - alexcrichton:update-cargo, r=aturon
afb9b20 
Update cargo submodule

This pulls in a fix for rust-lang#41797 to the master branch, I'll send a separate PR for
the beta branch. Note that the Cargo PR in question to pull in is rust-lang/cargo#4046
@nagisa nagisa added T-tools P-high High priority labels May 18, 2017
bors added a commit that referenced this issue May 21, 2017
@bors
Auto merge of #42040 - alexcrichton:beta-next, r=Mark-Simulacrum
f5b3def 
[beta] Update cargo submodule

This pulls in a fix for #41797 to the beta branch, and the relevant PR for Cargo
is rust-lang/cargo#4046

Closes #41797
@alexcrichton alexcrichton added T-cargo Relevant to the cargo team, which will review and decide on the PR/issue. and removed T-tools labels May 22, 2017
@alexcrichton
Copy link
Member

Ok, I think everything's landed here

@brson brson mentioned this issue Jun 1, 2017
Closed
# for free to join this conversation on GitHub. Already have an account? # to comment
Assignees
No one assigned
Labels
P-high High priority regression-from-stable-to-beta Performance or correctness regression from stable to beta. T-cargo Relevant to the cargo team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Change inferring bin's name logic jmatraszek/cargo
5 participants
@alexcrichton @brson @jmatraszek @nagisa @Mark-Simulacrum