Skip to content

Tracking Issue for needs_drop #41890

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom
Closed
Gankra opened this issue May 10, 2017 · 5 comments · Fixed by #44639
Closed

Tracking Issue for needs_drop #41890

Gankra opened this issue May 10, 2017 · 5 comments · Fixed by #44639
Labels
B-unstable Blocker: Implemented in the nightly compiler and unstable. C-tracking-issue Category: An issue tracking the progress of sth. like the implementation of an RFC final-comment-period In the final comment period and will be merged soon unless new substantive objections are raised. T-libs-api Relevant to the library API team, which will review and decide on the PR/issue.

Comments

@Gankra
Copy link
Contributor

Gankra commented May 10, 2017

About to submit a PR for exposing intrinsics::needs_drop under mem. Needs a tracking issue.

Here it is!
@nagisa nagisa added B-unstable Blocker: Implemented in the nightly compiler and unstable. T-libs-api Relevant to the library API team, which will review and decide on the PR/issue. labels May 11, 2017
@nagisa
Copy link
Member

nagisa commented May 11, 2017

The PR is #41892

@LukasKalbertodt LukasKalbertodt mentioned this issue Jun 20, 2017
Closed
@Mark-Simulacrum Mark-Simulacrum added the C-tracking-issue Category: An issue tracking the progress of sth. like the implementation of an RFC label Jul 22, 2017
@alexcrichton
Copy link
Member

@rfcbot fcp merge

Seems like this may be good to stabilize!

@rfcbot rfcbot added the proposed-final-comment-period Proposed to merge/close by relevant subteam, see T-<team> label. Will enter FCP once signed off. label Aug 29, 2017
@rfcbot
Copy link
Collaborator

rfcbot commented Aug 29, 2017 •
edited by Kimundi
Loading

Team member @alexcrichton has proposed to merge this. The next step is review by the rest of the tagged teams:

No concerns currently listed.

Once these reviewers reach consensus, this will enter its final comment period. If you spot a major issue that hasn't been raised at any point in this process, please speak up!

See this document for info about what commands tagged team members can give me.

@rfcbot
Copy link
Collaborator

rfcbot commented Sep 5, 2017

🔔 This is now entering its final comment period, as per the review above. 🔔

@rfcbot rfcbot added final-comment-period In the final comment period and will be merged soon unless new substantive objections are raised. and removed proposed-final-comment-period Proposed to merge/close by relevant subteam, see T-<team> label. Will enter FCP once signed off. labels Sep 5, 2017
@rfcbot
Copy link
Collaborator

rfcbot commented Sep 15, 2017

The final comment period is now complete.

budziq added a commit to budziq/rust that referenced this issue Sep 16, 2017
@budziq
stabilized needs_drop (fixes rust-lang#41890)
0485595
@budziq budziq mentioned this issue Sep 17, 2017
Merged
TimNN added a commit to TimNN/rust that referenced this issue Sep 17, 2017
@TimNN
Rollup merge of rust-lang#44639 - budziq:stabilize_needs_drop, r=dtolnay
dfbf8e3 
stabilized needs_drop (fixes rust-lang#41890)

fixes rust-lang#41890
TimNN added a commit to TimNN/rust that referenced this issue Sep 17, 2017
@TimNN
Rollup merge of rust-lang#44639 - budziq:stabilize_needs_drop, r=dtolnay
7019666 
stabilized needs_drop (fixes rust-lang#41890)

fixes rust-lang#41890
TimNN added a commit to TimNN/rust that referenced this issue Sep 17, 2017
@TimNN
Rollup merge of rust-lang#44639 - budziq:stabilize_needs_drop, r=dtolnay
d046421 
stabilized needs_drop (fixes rust-lang#41890)

fixes rust-lang#41890
dtolnay pushed a commit to dtolnay/rust that referenced this issue Sep 25, 2017
@budziq @dtolnay
stabilized needs_drop (fixes rust-lang#41890)
00cd2d6
# for free to join this conversation on GitHub. Already have an account? # to comment
Assignees
No one assigned
Labels
B-unstable Blocker: Implemented in the nightly compiler and unstable. C-tracking-issue Category: An issue tracking the progress of sth. like the implementation of an RFC final-comment-period In the final comment period and will be merged soon unless new substantive objections are raised. T-libs-api Relevant to the library API team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

stabilized needs_drop (fixes #41890) budziq/rust
5 participants
@alexcrichton @nagisa @Gankra @Mark-Simulacrum @rfcbot