Skip to content

MAKEFLAGS and nmake.exe with Cargo conflict #42635

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom
Closed
alexcrichton opened this issue Jun 13, 2017 · 4 comments · Fixed by rust-lang/cargo#4275
Closed

MAKEFLAGS and nmake.exe with Cargo conflict #42635

alexcrichton opened this issue Jun 13, 2017 · 4 comments · Fixed by rust-lang/cargo#4275
Assignees
@alexcrichton
Labels
I-needs-decision Issue: In need of a decision. P-high High priority regression-from-stable-to-beta Performance or correctness regression from stable to beta. T-cargo Relevant to the cargo team, which will review and decide on the PR/issue.

Comments

@alexcrichton
Copy link
Member

I'm filing this issue for tracking purposes but discussion should continue on rust-lang/cargo#4156 (comment) instead, just using this for labels so we don't forget it.
@alexcrichton alexcrichton added the regression-from-stable-to-beta Performance or correctness regression from stable to beta. label Jun 13, 2017
@alexcrichton alexcrichton self-assigned this Jun 13, 2017
@alexcrichton alexcrichton mentioned this issue Jun 13, 2017
Closed
@brson brson added P-high High priority T-cargo Relevant to the cargo team, which will review and decide on the PR/issue. I-needs-decision Issue: In need of a decision. labels Jun 15, 2017
@brson
Copy link
Contributor

brson commented Jul 7, 2017 •
edited
Loading

AFAICT this will affect most every Rust project building on Windows. I've seen this many times.

@brson brson mentioned this issue Jul 7, 2017
Closed
@alexcrichton alexcrichton mentioned this issue Jul 12, 2017
Merged
bors added a commit to rust-lang/cargo that referenced this issue Jul 12, 2017
@bors
Auto merge of #4275 - alexcrichton:revert-makeflags, r=alexcrichton
5982cf9 
Don't set MAKEFLAGS for build scripts

Closes #4156
Closes rust-lang/rust#42635
@alexcrichton alexcrichton mentioned this issue Jul 12, 2017
Merged
alexcrichton added a commit to alexcrichton/cargo that referenced this issue Jul 12, 2017
@alexcrichton
Don't set MAKEFLAGS for build scripts
ad5a408 
Closes rust-lang#4156
Closes rust-lang/rust#42635
@brson
Copy link
Contributor

brson commented Jul 13, 2017

Looks like this hasn't been backported into rust yet.

@brson brson reopened this Jul 13, 2017
bors added a commit to rust-lang/cargo that referenced this issue Jul 13, 2017
@bors
Auto merge of #4276 - alexcrichton:revert2, r=alexcrichton
e7a185b 
[beta] Don't set MAKEFLAGS for build scripts

Closes #4156
Closes rust-lang/rust#42635
@alexcrichton alexcrichton mentioned this issue Jul 13, 2017
Merged
@alexcrichton
Copy link
Member Author

@brson
Copy link
Contributor

brson commented Jul 14, 2017

Should be fixed on current beta 4. Anybody confirm?

bors added a commit that referenced this issue Jul 15, 2017
@bors
Auto merge of #43207 - alexcrichton:update-cargo, r=nikomatsakis
c4373bd 
Update the `cargo` submodule

Notably pull in an update to the `jobserver` crate to have Cargo set the
`CARGO_MAKEFLAGS` environment variable instead of the `MAKEFLAGS` environment
variable.

cc #42635
# for free to join this conversation on GitHub. Already have an account? # to comment
Assignees

@alexcrichton alexcrichton

Labels
I-needs-decision Issue: In need of a decision. P-high High priority regression-from-stable-to-beta Performance or correctness regression from stable to beta. T-cargo Relevant to the cargo team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Don't set MAKEFLAGS for build scripts alexcrichton/cargo
2 participants
@alexcrichton @brson