Skip to content

x.py test with non-existent test directory should error #43121

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom
Closed
Havvy opened this issue Jul 8, 2017 · 4 comments
Closed

x.py test with non-existent test directory should error #43121

Havvy opened this issue Jul 8, 2017 · 4 comments
Labels
E-easy Call for participation: Easy difficulty. Experience needed to fix: Not much. Good first issue. E-mentor Call for participation: This issue has a mentor. Use #t-compiler/help on Zulip for discussion. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap)

Comments

@Havvy
Copy link
Contributor

Havvy commented Jul 8, 2017

./x.py test does-not-exist should spit out an error instead of being successful.

cc @GuillaumeGomez
@Mark-Simulacrum Mark-Simulacrum added the T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap) label Jul 8, 2017
@Mark-Simulacrum Mark-Simulacrum self-assigned this Jul 8, 2017
@PlasmaPower
Copy link
Contributor

This was confusing to me when I tried to specify a file for ./x.py test and it did nothing. 👍

@GuillaumeGomez
Copy link
Member

@Mark-Simulacrum: Still no news on this?

@Mark-Simulacrum
Copy link
Member

Well, I believe it'll be fixed within #43059. However, if someone would like to implement this, adding logic here https://github.com/rust-lang/rust/blob/master/src/bootstrap/step.rs#L1212 to check that all indices in the path array were visited seems fairly straightforward. I'll mark as E-mentor and unassign myself.

@Mark-Simulacrum Mark-Simulacrum removed their assignment Jul 10, 2017
@Mark-Simulacrum Mark-Simulacrum added E-mentor Call for participation: This issue has a mentor. Use #t-compiler/help on Zulip for discussion. E-easy Call for participation: Easy difficulty. Experience needed to fix: Not much. Good first issue. labels Jul 10, 2017
@GuillaumeGomez
Copy link
Member

Well, I wanted to do it myself. :p

@GuillaumeGomez GuillaumeGomez mentioned this issue Jul 10, 2017
Merged
frewsxcv added a commit to frewsxcv/rust that referenced this issue Jul 15, 2017
@frewsxcv
Rollup merge of rust-lang#43145 - GuillaumeGomez:build-error-if-nothi…
c3a8347 
…ng, r=Mark-Simulacrum

fail in case nothing to run was found

Fixes rust-lang#43121.

r? @Mark-Simulacrum
# for free to join this conversation on GitHub. Already have an account? # to comment
Assignees
No one assigned
Labels
E-easy Call for participation: Easy difficulty. Experience needed to fix: Not much. Good first issue. E-mentor Call for participation: This issue has a mentor. Use #t-compiler/help on Zulip for discussion. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap)
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@Havvy @GuillaumeGomez @Mark-Simulacrum @PlasmaPower