Skip to content

Tracking issue for String::retain #43874

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom
Closed
murarth opened this issue Aug 15, 2017 · 6 comments
Closed

Tracking issue for String::retain #43874

murarth opened this issue Aug 15, 2017 · 6 comments
Labels
B-unstable Blocker: Implemented in the nightly compiler and unstable. C-tracking-issue Category: An issue tracking the progress of sth. like the implementation of an RFC final-comment-period In the final comment period and will be merged soon unless new substantive objections are raised. T-libs-api Relevant to the library API team, which will review and decide on the PR/issue.

Comments

@murarth
Copy link
Contributor

murarth commented Aug 15, 2017

Tracking issue for method String::retain, introduced in #43500.
@murarth murarth mentioned this issue Aug 15, 2017
Merged
@Mark-Simulacrum Mark-Simulacrum added C-tracking-issue Category: An issue tracking the progress of sth. like the implementation of an RFC T-libs-api Relevant to the library API team, which will review and decide on the PR/issue. B-unstable Blocker: Implemented in the nightly compiler and unstable. labels Aug 20, 2017
@alercah
Copy link
Contributor

alercah commented Mar 7, 2018

Any reason not to stabilize?

@Mark-Simulacrum
Copy link
Member

@rust-lang/libs -- nominating for stabilization. This API was introduced about half a year ago and seems reasonable to stabilize.

@alexcrichton
Copy link
Member

@rfcbot fcp merge

Sounds good to me!

@rfcbot
Copy link
Collaborator

rfcbot commented Mar 7, 2018 •
edited by dtolnay
Loading

Team member @alexcrichton has proposed to merge this. The next step is review by the rest of the tagged teams:

No concerns currently listed.

Once a majority of reviewers approve (and none object), this will enter its final comment period. If you spot a major issue that hasn't been raised at any point in this process, please speak up!

See this document for info about what commands tagged team members can give me.

@rfcbot rfcbot added the proposed-final-comment-period Proposed to merge/close by relevant subteam, see T-<team> label. Will enter FCP once signed off. label Mar 7, 2018
@rfcbot rfcbot added final-comment-period In the final comment period and will be merged soon unless new substantive objections are raised. and removed proposed-final-comment-period Proposed to merge/close by relevant subteam, see T-<team> label. Will enter FCP once signed off. labels Mar 8, 2018
@rfcbot
Copy link
Collaborator

rfcbot commented Mar 8, 2018

🔔 This is now entering its final comment period, as per the review above. 🔔

@rfcbot
Copy link
Collaborator

rfcbot commented Mar 18, 2018

The final comment period is now complete.

@murarth murarth mentioned this issue Mar 21, 2018
Merged
kennytm added a commit to kennytm/rust that referenced this issue Mar 28, 2018
@kennytm
Rollup merge of rust-lang#49243 - murarth:stabilize-retain, r=BurntSushi
43f56ce 
Stabilize method `String::retain`

Closes rust-lang#43874
# for free to join this conversation on GitHub. Already have an account? # to comment
Assignees
No one assigned
Labels
B-unstable Blocker: Implemented in the nightly compiler and unstable. C-tracking-issue Category: An issue tracking the progress of sth. like the implementation of an RFC final-comment-period In the final comment period and will be merged soon unless new substantive objections are raised. T-libs-api Relevant to the library API team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@alexcrichton @murarth @Mark-Simulacrum @rfcbot @alercah