-
Notifications
You must be signed in to change notification settings - Fork 13.4k
Replace all uses of fail
with die!
, then remove fail
and rename die!
to fail!
#4524
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
Comments
Can I get dibs on this? |
@nickdesaulniers you can! |
Just an update on the state of this bug: Step 1: Replace instances of fail with die!(), DONE TESTS GREEN This will be three separate commits, many changes, will probably take some time to review. I also missed a few instances of |
Actually, I may have overlooked one step. You may need to wait for a new snapshot before you can complete step 3, because the stage0 compiler currently has no idea what the |
Actually, until the
The joys of self-hosting! |
I think it can be done in one snap
|
Could fail just be a regular function? What magic does it do that requires it to be a syntax-extension/macro/magical-!-thing? Edit: Never mind I found some explanations here: #2232 |
Completely forgot to remove the definition of die in expand.rs |
Can this be closed? |
Yes, but I can't close it. I'm part of the Mozilla organization, but I don't have permissions for this repo. |
Thanks, @nickdesaulniers |
fail
is becoming a macro as per #3627, but first all uses of thefail
keyword must be removed. There's a new macro nameddie!
that can do the job offail
. Make the switch, then remove thefail
keyword from the parser and mass-renamedie!
tofail!
.The text was updated successfully, but these errors were encountered: