Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Documentation still refers to zero_memory and copy_memory #45606

Closed
dtolnay opened this issue Oct 29, 2017 · 1 comment
Closed

Documentation still refers to zero_memory and copy_memory #45606

dtolnay opened this issue Oct 29, 2017 · 1 comment
Labels
A-docs Area: Documentation for any part of the project, including the compiler, standard library, and tools C-cleanup Category: PRs that clean code up or issues documenting cleanup. E-easy Call for participation: Easy difficulty. Experience needed to fix: Not much. Good first issue.

Comments

@dtolnay
Copy link
Member

dtolnay commented Oct 29, 2017

The documentation of std::ptr::read and many other methods still refers to zero_memory and copy_memory which have since been removed or renamed.

src/libcore/ptr.rs
231: /// `zero_memory`, or `copy_memory`). Note that `*src = foo` counts as a use
267: /// `zero_memory`, or `copy_memory`). Note that `*src = foo` counts as a use
400: /// `zero_memory`, or `copy_memory`). Note that `*src = foo` counts as a use
874: /// `zero_memory`, or `copy_memory`). Note that `*self = foo` counts as a use
928: /// `zero_memory`, or `copy_memory`). Note that `*self = foo` counts as a use
964: /// `zero_memory`, or `copy_memory`). Note that `*self = foo` counts as a use
1572: /// `zero_memory`, or `copy_memory`). Note that `*self = foo` counts as a use
1626: /// `zero_memory`, or `copy_memory`). Note that `*self = foo` counts as a use
1662: /// `zero_memory`, or `copy_memory`). Note that `*self = foo` counts as a use
@dtolnay
Copy link
Member Author

dtolnay commented Oct 29, 2017

Looks like the relevant refactoring was done in #22729.

@kennytm kennytm added C-cleanup Category: PRs that clean code up or issues documenting cleanup. E-easy Call for participation: Easy difficulty. Experience needed to fix: Not much. Good first issue. A-docs Area: Documentation for any part of the project, including the compiler, standard library, and tools labels Oct 29, 2017
bors added a commit that referenced this issue Oct 29, 2017
Fix references to zero_memory and copy_memory in ptr docs

Fixes #45606
@dtolnay dtolnay changed the title Documentation stil refers to zero_memory and copy_memory Documentation still refers to zero_memory and copy_memory Oct 30, 2017
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
A-docs Area: Documentation for any part of the project, including the compiler, standard library, and tools C-cleanup Category: PRs that clean code up or issues documenting cleanup. E-easy Call for participation: Easy difficulty. Experience needed to fix: Not much. Good first issue.
Projects
None yet
Development

No branches or pull requests

2 participants