-
Notifications
You must be signed in to change notification settings - Fork 13.4k
Suggest removal of stray ;
after struct
definition
#46186
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
Labels
A-diagnostics
Area: Messages for errors, warnings, and lints
C-enhancement
Category: An issue proposing an enhancement or a PR with one.
E-easy
Call for participation: Easy difficulty. Experience needed to fix: Not much. Good first issue.
WG-diagnostics
Working group: Diagnostics
Comments
I'll take this one :) |
Newcomers from C++ are likely to hit this error. |
Merged
kennytm
added a commit
to kennytm/rust
that referenced
this issue
Nov 27, 2017
Remove semicolon note In reference to issue rust-lang#46186 r? @estebank First time doing a pull request, if there are any suggestions on how to improve this please let me know. @jjolly
Closing as fixed in #46258. Thanks for contribution! |
zackmdavis
added a commit
to zackmdavis/rust
that referenced
this issue
Jun 30, 2018
Previously (issue rust-lang#46186, pull-request rust-lang#46258), a suggestion was added to remove the semicolon after we fail to parse an item, but issue rust-lang#51603 complains that it's still insufficiently obvious why. Let's add a note. Resolves rust-lang#51603.
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Labels
A-diagnostics
Area: Messages for errors, warnings, and lints
C-enhancement
Category: An issue proposing an enhancement or a PR with one.
E-easy
Call for participation: Easy difficulty. Experience needed to fix: Not much. Good first issue.
WG-diagnostics
Working group: Diagnostics
For the given code
the output is only
where it should suggest removing the semicolon (as a suggestion so the RLS does the right thing)
This is an edge situation, but I feel it is a common enough typo I've made and that is very likely to happen to newcomers.
The text was updated successfully, but these errors were encountered: