Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Send and Sync impls of ::env types depend on implementation #48004

Closed
panicbit opened this issue Feb 4, 2018 · 0 comments · Fixed by #48005
Closed

Send and Sync impls of ::env types depend on implementation #48004

panicbit opened this issue Feb 4, 2018 · 0 comments · Fixed by #48005
Labels
C-enhancement Category: An issue proposing an enhancement or a PR with one.

Comments

@panicbit
Copy link
Contributor

panicbit commented Feb 4, 2018 •
edited
Loading

::env::{Args,ArgsOs,Vars,VarsOs} depend entirely on the platform impls in ::sys for their negative Send/Sync impls.
Implementations of those types currently opt out of Send and Sync, so the user facing types should probably explicitly opt out of Send/Sync to avoid accidental inconsistencies between platforms.
@panicbit panicbit mentioned this issue Feb 4, 2018
Merged
bors added a commit that referenced this issue Feb 5, 2018
@bors
Auto merge of #48005 - panicbit:env_unimpl_send_sync, r=<try>
7046949 
Unimplement Send/Sync for ::env::{Args,ArgsOs,Vars,VarsOs}

Fixes #48004
@TimNN TimNN added the C-enhancement Category: An issue proposing an enhancement or a PR with one. label Feb 6, 2018
kennytm added a commit to kennytm/rust that referenced this issue Feb 14, 2018
@kennytm
Rollup merge of rust-lang#48005 - panicbit:env_unimpl_send_sync, r=al…
c88a6fe 
…excrichton

Unimplement Send/Sync for ::env::{Args,ArgsOs,Vars,VarsOs}

Fixes rust-lang#48004
@SteveLauC SteveLauC mentioned this issue Dec 7, 2023
Open
# for free to join this conversation on GitHub. Already have an account? # to comment
Assignees
No one assigned
Labels
C-enhancement Category: An issue proposing an enhancement or a PR with one.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Unimplement Send/Sync for ::env::{Args,ArgsOs,Vars,VarsOs} panicbit/rust
2 participants
@panicbit @TimNN