Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

error_index_generator in 1.24.0 fails to build using 1.24.0, entity not found #48308

Closed
kyrias opened this issue Feb 17, 2018 · 9 comments
Closed

error_index_generator in 1.24.0 fails to build using 1.24.0, entity not found #48308

kyrias opened this issue Feb 17, 2018 · 9 comments
Labels
C-bug Category: This is a bug. P-high High priority regression-from-stable-to-stable Performance or correctness regression from one stable version to another. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap)

Comments

@kyrias
Copy link
Contributor

kyrias commented Feb 17, 2018

I can build rust 1.24.0 using our 1.23.0 package, but when I try to build 1.24.0 again using the 1.24.0 package I already built I get the following error during python2 ./x.py install:

Documenting error index (x86_64-unknown-linux-gnu)
Building stage2 tool error_index_generator (x86_64-unknown-linux-gnu)
   Compiling error_index_generator v0.0.0 (file:///build/rust/src/rustc-1.24.0-src/src/tools/error_index_generator)
    Finished release [optimized] target(s) in 4.3 secs
thread 'main' panicked at 'entity not found', tools/error_index_generator/main.rs:209:9
note: Run with `RUST_BACKTRACE=1` for a backtrace.


command did not execute successfully: "/build/rust/src/rustc-1.24.0-src/build/x86_64-unknown-linux-gnu/stage2-tools-bin/error_index_generator" "html" "/build/rust/src/rustc-1.24.0-src/build/x86_64-unknown-linux-gnu/doc/error-index.html"
expected success, got: exit code: 101


failed to run: /build/rust/src/rustc-1.24.0-src/build/bootstrap/debug/bootstrap install
Build completed unsuccessfully in 0:01:47
@Mark-Simulacrum
Copy link
Member

Looks like maybe we didn't generate the relevant metadata. Could you provide the full log by chance?

@kyrias
Copy link
Contributor Author

kyrias commented Feb 18, 2018

@Mark-Simulacrum https://ptpb.pw/bkT0

@Mark-Simulacrum Mark-Simulacrum added regression-from-stable-to-stable Performance or correctness regression from one stable version to another. C-bug Category: This is a bug. labels Feb 18, 2018
@cuviper
Copy link
Member

cuviper commented Feb 21, 2018

This was seen on Fedora too, in the build.log here:
https://koji.fedoraproject.org/koji/taskinfo?taskID=25212630

@kennytm kennytm added the T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap) label Feb 21, 2018
@cuviper
Copy link
Member

cuviper commented Feb 22, 2018

To get away from distro idiosyncrasies, I tried default builds of stable, beta, and nightly, just pointing each to their matching --local-rust-root ~/.rustup/toolchains/{stable,beta,nightly}... for a local rebuild. Stable (1.24) still failed, but beta and nightly were fine.

@cuviper
Copy link
Member

cuviper commented Feb 22, 2018

The actual error via strace is:

open("tmp/extended-errors/x86_64-unknown-linux-gnu", O_RDONLY|O_NONBLOCK|O_DIRECTORY|O_CLOEXEC) = -1 ENOENT (No such file or directory)

I strongly suspect we need 8c9bf66 from #47141.

@cuviper
Copy link
Member

cuviper commented Feb 22, 2018

I backported that commit to stable, without the unrelated stage0-diagnostic stuff, and it seems to work:
cuviper@b445a52

@Mark-Simulacrum
Copy link
Member

Thanks for experimenting! Since it's looking like we might be releasing 1.24.1 anyway (due to a variety of regressions that where detected post-release) I'll try to make sure that patch makes it into that.

@nikomatsakis
Copy link
Contributor

triage: P-high

Gotta get this fixed.

@rust-highfive rust-highfive added the P-high High priority label Feb 22, 2018
@Mark-Simulacrum Mark-Simulacrum mentioned this issue Feb 22, 2018
Merged
bors added a commit that referenced this issue Feb 27, 2018
@bors
Auto merge of #48445 - Mark-Simulacrum:stable-next, r=alexcrichton
d3ae9a9 
[stable] 1.24.1 stable release

The includes the following commits:
 - 6a600f8: Fixes #48251, unwinding through FFI no longer aborts
 - cuviper@b445a52: Fixes #48308, fixing the error index generator
 - f8e00d0: Fixes #48318 by emitting UTF-16 output on MSVC targets.
 - 2a0af8c448: Bumps the version number to 1.24.1.
 - 93220f0f45: Release notes
 - 6031718d8836f95bbfeddfaa63f1ee1d66e53f26: Cargo TLS warnings on Windows.
@cuviper
Copy link
Member

cuviper commented Mar 2, 2018

Fixed in 1.24.1.

@cuviper cuviper closed this as completed Mar 2, 2018
# for free to join this conversation on GitHub. Already have an account? # to comment
Assignees
No one assigned
Labels
C-bug Category: This is a bug. P-high High priority regression-from-stable-to-stable Performance or correctness regression from one stable version to another. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap)
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
6 participants
@cuviper @kennytm @nikomatsakis @kyrias @Mark-Simulacrum @rust-highfive