Skip to content

Provide a way to build the compiler with --error-format=json #48475

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom
Closed
Manishearth opened this issue Feb 23, 2018 · 3 comments
Closed

Provide a way to build the compiler with --error-format=json #48475

Manishearth opened this issue Feb 23, 2018 · 3 comments
Assignees
@Mark-Simulacrum
Labels
P-medium Medium priority T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap)

Comments

@Manishearth
Copy link
Member

Preferably as a flag to ./x.py; preferably such that the output gets stored in the build dir.

We already run cargo with --message-format=json so we may need to differentiate somehow.

cc @Mark-Simulacrum
@Mark-Simulacrum Mark-Simulacrum added P-medium Medium priority T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap) labels Feb 23, 2018
@Mark-Simulacrum
Copy link
Member

If someone would like to implement this I'd be happy to write up mentoring instructions, otherwise I'll probably do it sometime soon.

@Mark-Simulacrum Mark-Simulacrum self-assigned this Feb 23, 2018
@ghost
Copy link

ghost commented Feb 23, 2018

@Mark-Simulacrum has been mentoring me on this - I'll submit a pull request soon!

@ghost ghost mentioned this issue Feb 24, 2018
Merged
kennytm added a commit to kennytm/rust that referenced this issue Feb 25, 2018
@kennytm
Rollup merge of rust-lang#48517 - penpalperson:master, r=Mark-Simulacrum
eb0ab5e 
Added error-format flag to x.py.

Fixes rust-lang#48475

r? @Mark-Simulacrum
@Mark-Simulacrum
Copy link
Member

Opened #48558 to fix the missed fact that we hide JSON output anyway

# for free to join this conversation on GitHub. Already have an account? # to comment
Assignees

@Mark-Simulacrum Mark-Simulacrum

Labels
P-medium Medium priority T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap)
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@Manishearth @Mark-Simulacrum