Skip to content

🛠️ kill Predicate::Equate, which is dead code #48670

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Closed
nikomatsakis opened this issue Mar 2, 2018 · 1 comment
Closed

🛠️ kill Predicate::Equate, which is dead code #48670

nikomatsakis opened this issue Mar 2, 2018 · 1 comment
Assignees
Labels
A-trait-system Area: Trait system C-cleanup Category: PRs that clean code up or issues documenting cleanup. WG-traits Working group: Traits, https://internals.rust-lang.org/t/announcing-traits-working-group/6804

Comments

@nikomatsakis
Copy link
Contributor

Just to clean things up, we should remove Predicate::Equate, which is not used presently. I did this once, in the following commit, so you could start by cherry-picking it (or just use it as a guide):

nikomatsakis@6cd24a5

@nikomatsakis nikomatsakis added C-cleanup Category: PRs that clean code up or issues documenting cleanup. A-trait-system Area: Trait system WG-traits Working group: Traits, https://internals.rust-lang.org/t/announcing-traits-working-group/6804 labels Mar 2, 2018
@nikomatsakis
Copy link
Contributor Author

cc @rust-lang/wg-traits -- this is a simple refactoring, if you'd like to get your hands dirty and do a bit of a "dry run" on the PR authoring process. Feel free to ping me with questions, and you can put r? @nikomatsakis in the PR when you open it. =)

@ishitatsuyuki ishitatsuyuki self-assigned this Mar 4, 2018
alexcrichton added a commit to alexcrichton/rust that referenced this issue Mar 7, 2018
…tsakis

Remove ty::Predicate::Equate and ty::EquatePredicate (dead code)

r? @nikomatsakis

I also killed the EquatePredicate subsystem. Does it look fine?

Close rust-lang#48670
alexcrichton added a commit to alexcrichton/rust that referenced this issue Mar 7, 2018
…tsakis

Remove ty::Predicate::Equate and ty::EquatePredicate (dead code)

r? @nikomatsakis

I also killed the EquatePredicate subsystem. Does it look fine?

Close rust-lang#48670
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
A-trait-system Area: Trait system C-cleanup Category: PRs that clean code up or issues documenting cleanup. WG-traits Working group: Traits, https://internals.rust-lang.org/t/announcing-traits-working-group/6804
Projects
None yet
Development

No branches or pull requests

2 participants