Skip to content

Use of unicode_internals points people to issue #0 #49983

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Closed
alex opened this issue Apr 15, 2018 · 0 comments
Closed

Use of unicode_internals points people to issue #0 #49983

alex opened this issue Apr 15, 2018 · 0 comments

Comments

@alex
Copy link
Member

alex commented Apr 15, 2018

There is no issue #0 :-) I'm guessing someone intended #0 to mean "we don't have an issue for this", but either the error message emitting machinery needs to suppress it, or it should be given a real error message. Here's what it looks like:

error[E0658]: use of unstable library feature 'unicode_internals' (see issue #0)
  --> /home/travis/.cargo/registry/src/github.heygears.com-1ecc6299db9ec823/rustc-ap-syntax-94.0.0/parse/lexer/mod.rs:18:5
   |
18 | use std_unicode::property::Pattern_White_Space;
   |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
   |
   = help: add #![feature(unicode_internals)] to the crate attributes to enable
error[E0658]: use of unstable library feature 'unicode_internals' (see issue #0)
    --> /home/travis/.cargo/registry/src/github.heygears.com-1ecc6299db9ec823/rustc-ap-syntax-94.0.0/parse/lexer/mod.rs:1725:21
     |
1725 |     c.map_or(false, Pattern_White_Space)
     |                     ^^^^^^^^^^^^^^^^^^^
     |
     = help: add #![feature(unicode_internals)] to the crate attributes to enable
error: aborting due to 2 previous errors

You can see it here: https://travis-ci.org/alex/ct-tools/builds/366818424

zackmdavis added a commit to zackmdavis/rust that referenced this issue Apr 15, 2018
The unstable-feature attribute requires an issue (neglecting it is
E0547), which gets used in the error messages. Unfortunately, there are
some cases where "0" is apparently used a placeholder where no issue
exists, directing the user to see the (nonexistent) issue #0. (It would
have been better to either let `issue` be optional—compare to how issue
is an `Option<u32>` in the feature-gate declarations in
libsyntax/feature-gate.rs—or actually require that an issue be created.)
Rather than endeavoring to change how `#[unstable]` works at this time
(given competing contributor and reviewer priorities), this simple patch
proposes the less-ambitious solution of just not adding the "(see
issue)" note when the number is zero.

Resolves rust-lang#49983.
kennytm added a commit to kennytm/rust that referenced this issue Apr 24, 2018
don't see issue #0

The unstable-feature attribute requires an issue (neglecting it is
E0547), which gets used in the error messages. Unfortunately, there are
some cases where "0" is apparently used a placeholder where no issue
exists, directing the user to see the (nonexistent) issue #0. (It would
have been better to either let `issue` be optional—compare to how issue
is an `Option<u32>` in the feature-gate declarations in
libsyntax/feature-gate.rs—or actually require that an issue be created.)
Rather than endeavoring to change how `#[unstable]` works at this time
(given competing contributor and reviewer priorities), this simple patch
proposes the less-ambitious solution of just not adding the "(see
issue)" note when the number is zero.

Resolves rust-lang#49983.
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant