Skip to content

Factor out type size and alignment code from C ABI implementations #5116

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom
Closed
sanxiyn opened this issue Feb 26, 2013 · 6 comments
Closed

Factor out type size and alignment code from C ABI implementations #5116

sanxiyn opened this issue Feb 26, 2013 · 6 comments
Labels
A-codegen Area: Code generation C-cleanup Category: PRs that clean code up or issues documenting cleanup.

Comments

@sanxiyn
Copy link
Member

sanxiyn commented Feb 26, 2013

No description provided.

@emberian
Copy link
Member

emberian commented Jul 7, 2013

Still relevant

@pcwalton
Copy link
Contributor

Triage bump

@huonw
Copy link
Member

huonw commented Dec 19, 2013

Triage, still relevant. (Assuming this is about rustc::middle::trans::{cabi_arm, cabi_x86}, etc.)

@steveklabnik
Copy link
Member

Triage bump: not totally clear to me.

@sanxiyn
Copy link
Member Author

sanxiyn commented Jan 21, 2015

What is proposed here is to remove code duplications from rustc_trans::trans::cabi_*. Those modules define ty_size and ty_align functions, which are mostly but not exactly same as each other.

@steveklabnik
Copy link
Member

Triage: all of those files are still there. I am unsure if they are de-duplicated enough to satisfy this ticket.

@Mark-Simulacrum Mark-Simulacrum mentioned this issue Sep 25, 2016
Merged
sophiajt pushed a commit to sophiajt/rust that referenced this issue Sep 29, 2016
Rollup merge of rust-lang#36704 - Mark-Simulacrum:cleanup-cabi, r=Aatch
725d0f5 
Move ty_align and ty_size out of most C ABI code

s390x's C ABI ty_align and ty_size are not moved because the
implementation of ty_align varies in an atypical pattern: it calls
ty_size for the llvm::Vector type kind. ty_size then cannot be moved
since it indirectly calls ty_align through align.

Fixes rust-lang#5116 (probably, not sure).
bors added a commit to rust-lang-ci/rust that referenced this issue May 2, 2020
@bors
Auto merge of rust-lang#5116 - matthiaskrgr:rustup_29, r=flip1995
f3e2ccd 
update test stderr

changelog: none
# for free to join this conversation on GitHub. Already have an account? # to comment
Assignees
No one assigned
Labels
A-codegen Area: Code generation C-cleanup Category: PRs that clean code up or issues documenting cleanup.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@steveklabnik @sanxiyn @pcwalton @emberian @huonw