-
Notifications
You must be signed in to change notification settings - Fork 13.3k
panic_implementation: Error message talks about the panic_impl lang item when missing #51341
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
Comments
7 tasks
Under the hood we have replaced the old |
japaric
added a commit
to japaric/rust
that referenced
this issue
Jun 29, 2018
Mark-Simulacrum
added a commit
to Mark-Simulacrum/rust
that referenced
this issue
Jun 30, 2018
improve the error message when `#[panic_implementation]` is missing closes rust-lang#51341 r? @nagisa cc @phil-opp
kennytm
added a commit
to kennytm/rust
that referenced
this issue
Jun 30, 2018
improve the error message when `#[panic_implementation]` is missing closes rust-lang#51341 r? @nagisa cc @phil-opp
pietroalbini
added a commit
to pietroalbini/rust
that referenced
this issue
Jul 1, 2018
improve the error message when `#[panic_implementation]` is missing closes rust-lang#51341 r? @nagisa cc @phil-opp
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
If the new
panic_implementation
attribute is missing, the error message mentions the apanic_impl
lang item:Instead it should probably mention that a
panic_implementation
function is missing.Edit: Seems like I didn't read it carefully enough. The error message doesn't mention the old
panic_fmt
language item, but a newpanic_impl
language item. Either way, a error message mentioning thepanic_implementation
attribute would be better.The text was updated successfully, but these errors were encountered: