Skip to content

rustbuild: x.py doc -i --stage 1 src/libstd builds the compiler twice #51424

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Closed
QuietMisdreavus opened this issue Jun 7, 2018 · 2 comments
Closed
Labels
C-bug Category: This is a bug. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap)

Comments

@QuietMisdreavus
Copy link
Member

This seems to be new? I think in the past it worked without building the stage1 compiler. (At least, without the --incremental flag.) My current branch is based on master at 4122885.

Full build log with --verbose: https://gist.github.com/QuietMisdreavus/5d000903b7cc4f1aae655f7c9b3073b8

cc @Mark-Simulacrum

@kennytm kennytm added T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap) C-bug Category: This is a bug. labels Jun 7, 2018
@kennytm
Copy link
Member

kennytm commented Jun 7, 2018

(Hint: You could use ./x.py doc --stage 1 src/lib --dry-run -v to dump the build tree without actually building anything.)

I think this is old, because until #51302 we require a stage2 sysroot for anything rustdoc related. Perhaps need to update these lines:

if cmd != "build" && cmd != "check" && want_rustdoc {
cargo.env(
"RUSTDOC_LIBDIR",
self.rustc_libdir(self.compiler(2, self.config.build)),
);
}

@Mark-Simulacrum
Copy link
Member

Yes, those lines look like the problem. We probably just need to change the compiler argument to the compiler passed to the cargo function

Mark-Simulacrum added a commit to Mark-Simulacrum/rust that referenced this issue Jun 8, 2018
…Misdreavus

Do not require stage 2 compiler for rustdoc

r? @QuietMisdreavus

Fixes rust-lang#51424

I *think* this is correct; though I'm not certain. If it passes CI though I expect that to be good enough...
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
C-bug Category: This is a bug. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap)
Projects
None yet
Development

No branches or pull requests

3 participants