use can't resolve non-pub parent module through super

[brson]

This use statement doesn't resolve:

mod foo {
    pub fn bar() { }
}

mod baz {
    use super::foo;
    fn main() {
        foo::bar();
    }
}

This one does:

mod foo {
    pub fn bar() { }
}

mod baz {
    use super::foo::bar;
    fn main() {
        bar();
    }
}

[brson]

This is because without pub it's a chained import.

[graydon]

is it? there's only one 'use' in any case, I thought the chained-import restriction only applied there

[brson]

@graydon I'm not sure what I was thinking with that comment.

[pnkfelix]

linking to #6143 for unified tracking of resolve

[catamorphism]

This seems to be fixed. Checking in a test case.

[catamorphism]

Oh, never mind, I misunderstood the bug. With the unmodified code, I still get:

/Users/tjc/rust/src/test/run-pass/issue-5248.rs:16:8: 16:18 error: unresolved import: found `foo` in `???` but it is private
/Users/tjc/rust/src/test/run-pass/issue-5248.rs:16     use super::foo;
                                                           ^~~~~~~~~~
/Users/tjc/rust/src/test/run-pass/issue-5248.rs:16:8: 16:18 error: failed to resolve import `super::foo`
/Users/tjc/rust/src/test/run-pass/issue-5248.rs:16     use super::foo;
                                                           ^~~~~~~~~~

[catamorphism]

Nominating for milestone 5, production-ready

[catamorphism]

Moved to milestone 5

[alexcrichton]

Closing as a dupe of #8215. The rules in #8215 would disallow the first program (you can use private sibling modules), and the second program would be disallowed for the same reason.