Skip to content

Update SharedChan constructor to new conventions #5390

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom
Closed
brson opened this issue Mar 14, 2013 · 1 comment
Closed

Update SharedChan constructor to new conventions #5390

brson opened this issue Mar 14, 2013 · 1 comment
Labels
C-cleanup Category: PRs that clean code up or issues documenting cleanup. E-easy Call for participation: Easy difficulty. Experience needed to fix: Not much. Good first issue.

Comments

@brson
Copy link
Contributor

brson commented Mar 14, 2013

Should have a static new method.

Subset of #3853
@alexcrichton
Copy link
Member

This was fixed in decd390

bors added a commit to rust-lang-ci/rust that referenced this issue May 2, 2020
@bors
Auto merge of rust-lang#5390 - phansch:rustupp, r=matthiaskrgr
0254c42 
Rustup to rust-lang#70449

cc rust-lang#70449

changelog: none
calebcartwright pushed a commit to calebcartwright/rust that referenced this issue Jan 24, 2023
@davidBar-On
Backport PR rust-lang#4730 (rust-lang#5390)
ea017d7 
* Backport PR rust-lang#4730 that fix issue rust-lang#4689

* Test files for each Verion One and Two

* Simplify per review comment - use defer and matches!

* Changes per reviewer comments for reducing indentations
# for free to join this conversation on GitHub. Already have an account? # to comment
Assignees
No one assigned
Labels
C-cleanup Category: PRs that clean code up or issues documenting cleanup. E-easy Call for participation: Easy difficulty. Experience needed to fix: Not much. Good first issue.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@alexcrichton @brson