Remove LLVM GC patches, add ARM patches, remove clang, rebase onto trunk #5401
Labels
A-LLVM
Area: Code generation parts specific to LLVM. Both correctness bugs and optimization-related issues.
Milestone
Comments
|
Probably should also incorporate #3775 once we rebase to trunk. |
|
And #5403 |
Closed
|
Dupe of #5368 |
oli-obk
pushed a commit
to oli-obk/rust
that referenced
this issue
Apr 2, 2020
Downgrade option_option to pedantic
Based on a search of my work codebase (\>500k lines) for `Option<Option<`, it looks like a bunch of reasonable uses to me. The documented motivation for this lint is:
> an optional optional value is logically the same thing as an optional value but has an unneeded extra level of wrapping
which seems a bit bogus in practice. For example a typical usage would look like:
```rust
let mut host: Option<String> = None;
let mut port: Option<i32> = None;
let mut payload: Option<Option<String>> = None;
for each field {
match field.name {
"host" => host = Some(...),
"port" => port = Some(...),
"payload" => payload = Some(...), // can be null or string
_ => return error,
}
}
let host = host.ok_or(...)?;
let port = port.ok_or(...)?;
let payload = payload.ok_or(...)?;
do_thing(host, port, payload)
```
This lint seems to fit right in with the pedantic group; I don't think linting on occurrences of `Option<Option<T>>` by default is justified.
---
changelog: Remove option_option from default set of enabled lints
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
We have several LLVM changes in the pipeline. Let's do them all at once to avoid too much churn.
#5327 has a number of changes to support
__morestackon ARM. Today I'm going to take that branch and try to rebase out our GC patches.@yichoi (or @ILyoan - I can't recall) also mentioned on Wednesday that they want to update LLVM to trunk to pick up some ARM fixes.
@ILyoan @yichoi are there any other modifications you expect to LLVM before 0.6?
The text was updated successfully, but these errors were encountered: