-
Notifications
You must be signed in to change notification settings - Fork 13.3k
remap-debuginfo config.toml option broken when building a release #55341
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
Comments
Keruspe
added a commit
to Keruspe/rust
that referenced
this issue
Oct 25, 2018
Fallback to the release number as we can't get the git commit sha as we're not in a git repository. Fixes rust-lang#55341 Signed-off-by: Marc-Antoine Perennou <Marc-Antoine@Perennou.com>
kennytm
added a commit
to kennytm/rust
that referenced
this issue
Oct 26, 2018
…alexcrichton rustbuild: fix remap-debuginfo when building a release Fallback to the release number as we can't get the git commit sha as we're not in a git repository. Fixes rust-lang#55341
kennytm
added a commit
to kennytm/rust
that referenced
this issue
Oct 26, 2018
…alexcrichton rustbuild: fix remap-debuginfo when building a release Fallback to the release number as we can't get the git commit sha as we're not in a git repository. Fixes rust-lang#55341
pietroalbini
pushed a commit
to pietroalbini/rust
that referenced
this issue
Oct 31, 2018
Fallback to the release number as we can't get the git commit sha as we're not in a git repository. Fixes rust-lang#55341 Signed-off-by: Marc-Antoine Perennou <Marc-Antoine@Perennou.com>
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Trying to build 1.30.0 with remap-debuginfo enabled results in
thread 'main' panicked at 'failed to find sha', libcore/option.rs:989:5
rustbuild tries to get the sha from the current commit when we are not in a git repository
The text was updated successfully, but these errors were encountered: