Skip to content

run-make tests should have a way to ignore targets #56704

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom
Closed
euclio opened this issue Dec 11, 2018 · 0 comments
Closed

run-make tests should have a way to ignore targets #56704

euclio opened this issue Dec 11, 2018 · 0 comments
Labels
A-testsuite Area: The testsuite used to check the correctness of rustc T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap)

Comments

@euclio
Copy link
Contributor

euclio commented Dec 11, 2018 •
edited
Loading

Currently, run-make targets that only run on particular targets do so by using the preprocessor:

rust/src/test/run-make-fulldeps/windows-spawn/Makefile

Lines 3 to 14 in b7c6e8f

ifdef IS_WINDOWS
all:
$(RUSTC) -o "$(TMPDIR)/hopefullydoesntexist bar.exe" hello.rs
$(RUSTC) spawn.rs
$(TMPDIR)/spawn.exe
else
all:
endif

This hurts readability and causes the tests to show up as "passed" on platforms where they aren't run. It would be nice if these tests could write a comment such as # ignore-windows or # only-windows and have the tests show up as ignored, like UI tests.
@estebank estebank added A-testsuite Area: The testsuite used to check the correctness of rustc T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap) labels Dec 12, 2018
@euclio euclio mentioned this issue Jan 6, 2019
Merged
euclio added a commit to euclio/rust that referenced this issue Jan 7, 2019
@euclio
use ignore directives for run-make tests
0f70c06 
This makes the tests easier to read, and makes it possible to tell which
tests aren't being run on the host platform.

Fixes rust-lang#56704.
bors added a commit that referenced this issue Jan 14, 2019
@bors
Auto merge of #57388 - euclio:runmake-explicit-ignore, r=kennytm
cc28392 
use ignore directives for run-make tests

This makes the tests easier to read, and makes it possible to tell which
tests aren't being run on the host platform.

Fixes #56704.
euclio added a commit to euclio/rust that referenced this issue Feb 11, 2019
@euclio
use ignore directives for run-make tests
f15d20c 
This makes the tests easier to read, and makes it possible to tell which
tests aren't being run on the host platform.

Fixes rust-lang#56704.
bors added a commit that referenced this issue Feb 12, 2019
@bors
Auto merge of #57388 - euclio:runmake-explicit-ignore, r=kennytm
a54b5c7 
use ignore directives for run-make tests

This makes the tests easier to read, and makes it possible to tell which
tests aren't being run on the host platform.

Fixes #56704.
# for free to join this conversation on GitHub. Already have an account? # to comment
Assignees
No one assigned
Labels
A-testsuite Area: The testsuite used to check the correctness of rustc T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap)
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@euclio @estebank