Skip to content

Fails to bootstrap with system Rust 1.33 #57262

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Closed
jbeich opened this issue Jan 2, 2019 · 2 comments
Closed

Fails to bootstrap with system Rust 1.33 #57262

jbeich opened this issue Jan 2, 2019 · 2 comments
Labels
T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap) T-infra Relevant to the infrastructure team, which will review and decide on the PR/issue.

Comments

@jbeich
Copy link

jbeich commented Jan 2, 2019

After aecf8c2 + cf47a19

$ /usr/local/bin/rustc -vV
rustc 1.33.0-nightly
binary: rustc
commit-hash: 9eac386342c6
commit-date: 2018-12-31
host: x86_64-unknown-freebsd
release: 1.33.0-nightly
LLVM version: 8.0

$ cat config.toml
[build]
...
rustc = "/usr/local/bin/rustc"
cargo = "/usr/local/bin/cargo"
...
$ ./x.py build
[...]
error: use of deprecated item 'core::str::<impl str>::trim_left_matches': superseded by `trim_start_matches`
   --> src/bootstrap/lib.rs:423:30
    |
423 |             .next().unwrap().trim_left_matches("release:").trim();
    |                              ^^^^^^^^^^^^^^^^^
    |
note: lint level defined here
   --> src/bootstrap/lib.rs:107:9
    |
107 | #![deny(warnings)]
    |         ^^^^^^^^
    = note: #[deny(deprecated)] implied by #[deny(warnings)]

error: use of deprecated item 'core::str::<impl str>::trim_left_matches': superseded by `trim_start_matches`
   --> src/bootstrap/dist.rs:227:18
    |
227 |                 .trim_left_matches(trim_chars)
    |                  ^^^^^^^^^^^^^^^^^

error: aborting due to 2 previous errors
error: Could not compile `bootstrap`.
@jbeich jbeich changed the title Cannot bootstrap with system Rust 1.33 Fails to bootstrap with system Rust 1.33 Jan 2, 2019
@Centril Centril added T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap) T-infra Relevant to the infrastructure team, which will review and decide on the PR/issue. labels Jan 2, 2019
@Keruspe
Copy link
Contributor

Keruspe commented Jan 21, 2019

src/bootstrap changes from #57765 should probably be backported to beta

Keruspe added a commit to Keruspe/rust that referenced this issue Jan 30, 2019
Fixes rust-lang#57262

Signed-off-by: Marc-Antoine Perennou <Marc-Antoine@Perennou.com>
bors added a commit that referenced this issue Jan 31, 2019
[beta] rustbuild: fix build with rust 1.33

Fixes #57262
@Keruspe
Copy link
Contributor

Keruspe commented Jan 31, 2019

I think this can be closed now

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap) T-infra Relevant to the infrastructure team, which will review and decide on the PR/issue.
Projects
None yet
Development

No branches or pull requests

4 participants