Skip to content

Guarantee that the complex number type is compatible with the C representation #5737

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom
Closed
thestinger opened this issue Apr 5, 2013 · 3 comments
Closed

Guarantee that the complex number type is compatible with the C representation #5737

thestinger opened this issue Apr 5, 2013 · 3 comments
Labels
E-easy Call for participation: Easy difficulty. Experience needed to fix: Not much. Good first issue.

Comments

@thestinger
Copy link
Contributor

This would just mean packing the struct representation.

I think it's probably already equivalent on every platform Rust runs on right now though...
@thestinger thestinger mentioned this issue Apr 5, 2013
Closed
@msullivan
Copy link
Contributor

What do you mean by packing the struct representation? Do we have a pack directive?

@Aatch
Copy link
Contributor

Aatch commented Jul 29, 2013

@msullivan yes, we do: #[packed]

@thestinger
Copy link
Contributor Author

Closing in favour of #10500. This is worse than I thought.

flip1995 pushed a commit to flip1995/rust that referenced this issue Jul 17, 2020
@bors
Auto merge of rust-lang#5737 - Uriopass:unit-for-ord, r=flip1995
97d7a8b 
Reprise: new lint: Unintentional return of unit from closures expecting Ord

This lint catches cases where the last statement of a closure expecting
an instance of Ord has a trailing semi-colon. It compiles since the
closure ends up return () which also implements Ord but causes
unexpected results in cases such as sort_by_key.

Fixes rust-lang#5080

Reprise of rust-lang#5348 where I addressed all the comments there

changelog: add lint [`unit_return_expecting_ord`]
# for free to join this conversation on GitHub. Already have an account? # to comment
Assignees
No one assigned
Labels
E-easy Call for participation: Easy difficulty. Experience needed to fix: Not much. Good first issue.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@msullivan @Aatch @thestinger