Skip to content

rustdoc JS on doc.r-l.o is not working on nightly #58290

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom
Closed
Mark-Simulacrum opened this issue Feb 8, 2019 · 3 comments
Closed

rustdoc JS on doc.r-l.o is not working on nightly #58290

Mark-Simulacrum opened this issue Feb 8, 2019 · 3 comments
Labels
C-bug Category: This is a bug. regression-from-stable-to-nightly Performance or correctness regression from stable to nightly. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue.

Comments

@Mark-Simulacrum
Copy link
Member 

SyntaxError: missing ) after argument list[Learn More] main.js:1:38574
ReferenceError: initSearch is not defined[Learn More] search-index.js:8:1
    <anonymous> https://doc.rust-lang.org/nightly/search-index.js:8

cc @GuillaumeGomez @QuietMisdreavus
@Mark-Simulacrum Mark-Simulacrum added the T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue. label Feb 8, 2019
@Mark-Simulacrum Mark-Simulacrum pinned this issue Feb 8, 2019
@Mark-Simulacrum Mark-Simulacrum changed the title rustdoc search is not working on nightly rustdoc JS on doc.r-l.o is not working on nightly Feb 8, 2019
@RalfJung
Copy link
Member

RalfJung commented Feb 8, 2019 •
edited
Loading

I suppose this is the reason that search on https://doc.rust-lang.org/nightly/std/index.html is broken.

@jonas-schievink jonas-schievink added regression-from-stable-to-nightly Performance or correctness regression from stable to nightly. C-bug Category: This is a bug. labels Feb 8, 2019
@Mark-Simulacrum
Copy link
Member Author

Yes, this will prevent any JS from working across nightly-built docs until this is fixed.

@hrls hrls mentioned this issue Feb 8, 2019
Merged
bors added a commit that referenced this issue Feb 8, 2019
@bors
Auto merge of #58294 - hrls:master, r=GuillaumeGomez
0710c20 
fix rustdoc JS

#58290
@kennytm
Copy link
Member

kennytm commented Feb 9, 2019

This has been fixed by #58294, and a nightly has been released. Closing.

@kennytm kennytm closed this as completed Feb 9, 2019
@kennytm kennytm unpinned this issue Feb 9, 2019
# for free to join this conversation on GitHub. Already have an account? # to comment
Assignees
No one assigned
Labels
C-bug Category: This is a bug. regression-from-stable-to-nightly Performance or correctness regression from stable to nightly. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@kennytm @RalfJung @jonas-schievink @Mark-Simulacrum