Skip to content

Const generic parameters have incorrect hygiene #58307

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom
Closed
varkor opened this issue Feb 8, 2019 · 2 comments · Fixed by #63083
Closed

Const generic parameters have incorrect hygiene #58307

varkor opened this issue Feb 8, 2019 · 2 comments · Fixed by #63083
Labels
A-const-generics Area: const generics (parameters and arguments) C-bug Category: This is a bug. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.

Comments

@varkor
Copy link
Member

varkor commented Feb 8, 2019 •
edited
Loading

Const generic parameters are treated as hygienic by macro_rule because it uses "let variable hygiene" rather than "item hygiene".

See #57523 (comment) and #58191 (comment).

cc @petrochenkov
@jonas-schievink jonas-schievink added T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. C-bug Category: This is a bug. labels Feb 9, 2019
@jonas-schievink
Copy link
Contributor

cc #44580

@varkor varkor mentioned this issue Mar 21, 2019
Closed
16 tasks
@varkor
Copy link
Member Author

varkor commented Mar 21, 2019

#44580 (comment) looks like it could be related to this issue.

@varkor varkor added the A-const-generics Area: const generics (parameters and arguments) label Mar 21, 2019
@varkor varkor mentioned this issue May 11, 2019
Closed
@L117 L117 mentioned this issue Jun 6, 2019
Closed
@petrochenkov petrochenkov mentioned this issue Jul 6, 2019
Closed
@matthewjasper matthewjasper mentioned this issue Jul 28, 2019
Merged
Centril added a commit to Centril/rust that referenced this issue Jul 29, 2019
@Centril
Rollup merge of rust-lang#63083 - matthewjasper:parameter-hygiene, r=…
16a733b 
…petrochenkov

Make generic parameters always use modern hygiene

* E0263 (lifetime parameter declared twice in the same scope) now compares modernized identifiers.
* Const parameters are now resolved with modern hygiene.

Closes rust-lang#58307
Closes rust-lang#60746
Closes rust-lang#61574
Closes rust-lang#62433
Centril added a commit to Centril/rust that referenced this issue Jul 30, 2019
@Centril
Rollup merge of rust-lang#63083 - matthewjasper:parameter-hygiene, r=…
cbce93c 
…petrochenkov

Make generic parameters always use modern hygiene

* E0263 (lifetime parameter declared twice in the same scope) now compares modernized identifiers.
* Const parameters are now resolved with modern hygiene.

Closes rust-lang#58307
Closes rust-lang#60746
Closes rust-lang#61574
Closes rust-lang#62433
Centril added a commit to Centril/rust that referenced this issue Jul 30, 2019
@Centril
Rollup merge of rust-lang#63083 - matthewjasper:parameter-hygiene, r=…
652f13d 
…petrochenkov

Make generic parameters always use modern hygiene

* E0263 (lifetime parameter declared twice in the same scope) now compares modernized identifiers.
* Const parameters are now resolved with modern hygiene.

Closes rust-lang#58307
Closes rust-lang#60746
Closes rust-lang#61574
Closes rust-lang#62433
# for free to join this conversation on GitHub. Already have an account? # to comment
Assignees
No one assigned
Labels
A-const-generics Area: const generics (parameters and arguments) C-bug Category: This is a bug. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Make generic parameters always use modern hygiene matthewjasper/rust
2 participants
@jonas-schievink @varkor