Skip to content

rls no longer builds after rust-lang/rust#58140 #59218

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Closed
rust-highfive opened this issue Mar 15, 2019 · 3 comments
Closed

rls no longer builds after rust-lang/rust#58140 #59218

rust-highfive opened this issue Mar 15, 2019 · 3 comments
Assignees
Labels
T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.

Comments

@rust-highfive
Copy link
Contributor

Hello, this is your friendly neighborhood mergebot.
After merging PR #58140, I observed that the tool rls no longer builds.
A follow-up PR to the repository https://github.com/rust-lang/rls is needed to fix the fallout.

cc @eddyb, do you think you would have time to do the follow-up work?
If so, that would be great!

cc @nikomatsakis, the PR reviewer, and @rust-lang/compiler -- nominating for prioritization.

@rust-highfive rust-highfive added I-nominated T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Mar 15, 2019
@kennytm
Copy link
Member

kennytm commented Mar 15, 2019

Error is caused by clippy-lints dependency.

[01:26:39] error[E0433]: failed to resolve: could not find `item_path` in `ty`
[01:26:39]    --> src/tools/clippy/clippy_lints/src/utils/mod.rs:104:10
[01:26:39]     |
[01:26:39] 104 | impl ty::item_path::ItemPathBuffer for AbsolutePathBuffer {
[01:26:39]     |          ^^^^^^^^^ could not find `item_path` in `ty`
[01:26:39] 
[01:26:39] error[E0433]: failed to resolve: could not find `item_path` in `ty`
[01:26:39]    --> src/tools/clippy/clippy_lints/src/utils/mod.rs:105:33
[01:26:39]     |
[01:26:39] 105 |     fn root_mode(&self) -> &ty::item_path::RootMode {
[01:26:39]     |                                 ^^^^^^^^^ could not find `item_path` in `ty`
[01:26:39] 
[01:26:39] error[E0433]: failed to resolve: could not find `item_path` in `ty`
[01:26:39]    --> src/tools/clippy/clippy_lints/src/utils/mod.rs:106:30
[01:26:39]     |
[01:26:39] 106 |         const ABSOLUTE: &ty::item_path::RootMode = &ty::item_path::RootMode::Absolute;
[01:26:39]     |                              ^^^^^^^^^ could not find `item_path` in `ty`
[01:26:39] 
[01:26:39] error[E0433]: failed to resolve: could not find `item_path` in `ty`
[01:26:39]    --> src/tools/clippy/clippy_lints/src/utils/mod.rs:106:57
[01:26:39]     |
[01:26:39] 106 |         const ABSOLUTE: &ty::item_path::RootMode = &ty::item_path::RootMode::Absolute;
[01:26:39]     |                                                         ^^^^^^^^^ could not find `item_path` in `ty`
[01:26:39] 
[01:26:40] error: aborting due to 4 previous errors

@mati865
Copy link
Contributor

mati865 commented Mar 15, 2019

I'm on it.

@eddyb
Copy link
Member

eddyb commented Mar 15, 2019

@mati865 I would like to review the resulting PR, if you don't mind. You can also PM me (on IRC/Discord) if you have any questions.

bors added a commit that referenced this issue Mar 19, 2019
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Development

No branches or pull requests

6 participants