Skip to content

Use declare_lint_pass! for internal lints #59683

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom
Closed
Centril opened this issue Apr 3, 2019 · 1 comment
Closed

Use declare_lint_pass! for internal lints #59683

Centril opened this issue Apr 3, 2019 · 1 comment
Labels
A-lints Area: Lints (warnings about flaws in source code) such as unused_mut. C-cleanup Category: PRs that clean code up or issues documenting cleanup. E-easy Call for participation: Easy difficulty. Experience needed to fix: Not much. Good first issue. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.

Comments

@Centril
Copy link
Contributor

Centril commented Apr 3, 2019

In #59669 a declare_lint_pass! macro is introduced. In #59316 two new lints are added that don't use this macro. This issue tracks fixing that.

cc @oli-obk @flip1995
@Centril Centril added E-easy Call for participation: Easy difficulty. Experience needed to fix: Not much. Good first issue. C-cleanup Category: PRs that clean code up or issues documenting cleanup. A-lints Area: Lints (warnings about flaws in source code) such as unused_mut. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Apr 3, 2019
@hgallagher1993
Copy link
Contributor

Ya I'll take this on 👍

@hgallagher1993 hgallagher1993 mentioned this issue Apr 4, 2019
Merged
Centril added a commit to Centril/rust that referenced this issue Apr 5, 2019
@Centril
Rollup merge of rust-lang#59702 - hgallagher1993:origin, r=Centril
3600e4d 
Use declare_lint_pass! and impl_lint_pass! in more places

Fixes rust-lang#59683
Centril added a commit to Centril/rust that referenced this issue Apr 5, 2019
@Centril
Rollup merge of rust-lang#59702 - hgallagher1993:origin, r=Centril
c0ed443 
Use declare_lint_pass! and impl_lint_pass! in more places

Fixes rust-lang#59683
# for free to join this conversation on GitHub. Already have an account? # to comment
Assignees
No one assigned
Labels
A-lints Area: Lints (warnings about flaws in source code) such as unused_mut. C-cleanup Category: PRs that clean code up or issues documenting cleanup. E-easy Call for participation: Easy difficulty. Experience needed to fix: Not much. Good first issue. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@Centril @hgallagher1993