Skip to content

rustdoc shows default keyword on re-exported trait methods with default implementation #59977

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom
Closed
ollie27 opened this issue Apr 14, 2019 · 0 comments · Fixed by #59978
Closed

rustdoc shows default keyword on re-exported trait methods with default implementation #59977

ollie27 opened this issue Apr 14, 2019 · 0 comments · Fixed by #59978
Labels
C-bug Category: This is a bug. regression-from-stable-to-beta Performance or correctness regression from stable to beta. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue.

Comments

@ollie27
Copy link
Member

ollie27 commented Apr 14, 2019

for example on std::clone::Clone:
image

On core::clone::Clone it displays correctly:
image

This is a stable to beta regression caused by #58927.
@ollie27 ollie27 mentioned this issue Apr 14, 2019
Merged
@jonas-schievink jonas-schievink added T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue. C-bug Category: This is a bug. regression-from-stable-to-beta Performance or correctness regression from stable to beta. labels Apr 15, 2019
Centril added a commit to Centril/rust that referenced this issue Apr 15, 2019
@Centril
Rollup merge of rust-lang#59978 - ollie27:rustdoc_default, r=QuietMis…
fb2ce84 
…dreavus

rustdoc: Remove default keyword from re-exported trait methods

Fixes rust-lang#59977

r? @QuietMisdreavus

As this fixes a stable to beta regression, could it be backported?
# for free to join this conversation on GitHub. Already have an account? # to comment
Assignees
No one assigned
Labels
C-bug Category: This is a bug. regression-from-stable-to-beta Performance or correctness regression from stable to beta. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

rustdoc: Remove default keyword from re-exported trait methods ollie27/rust
2 participants
@jonas-schievink @ollie27