Skip to content

Remove abort_if_errors before borrow checking #60005

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom
Closed
estebank opened this issue Apr 16, 2019 · 2 comments · Fixed by #60125
Closed

Remove abort_if_errors before borrow checking #60005

estebank opened this issue Apr 16, 2019 · 2 comments · Fixed by #60125
Labels
A-diagnostics Area: Messages for errors, warnings, and lints C-cleanup Category: PRs that clean code up or issues documenting cleanup. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.

Comments

@estebank
Copy link
Contributor

Filed as per #59903 (comment)

When removing abort_if_errors call right before borrow checking, the fallout from the change causes multiple duplicated errors (which can be deduplicated with little effort) and a couple of ICEs.

We should make an effort to fix these issues and remove the abort_if_errors call.
@estebank estebank added C-cleanup Category: PRs that clean code up or issues documenting cleanup. A-diagnostics Area: Messages for errors, warnings, and lints T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Apr 16, 2019
@estebank
Copy link
Contributor Author

Once implemented, this will close #30999.

@estebank
Copy link
Contributor Author

CC #30418, as eliding some of the errors caused by the removal fall under it.

@estebank estebank mentioned this issue Apr 19, 2019
Merged
bors added a commit that referenced this issue Apr 23, 2019
@bors
Auto merge of #60125 - estebank:continue-evaluating, r=oli-obk
31f5d69 
Don't stop evaluating due to errors before borrow checking

r? @oli-obk

Fix #60005. Follow up to #59903. Blocked on #53708, fixing the ICE in `src/test/ui/consts/match_ice.rs`.
# for free to join this conversation on GitHub. Already have an account? # to comment
Assignees
No one assigned
Labels
A-diagnostics Area: Messages for errors, warnings, and lints C-cleanup Category: PRs that clean code up or issues documenting cleanup. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Don't stop evaluating due to errors before borrow checking estebank/rust
1 participant
@estebank