Skip to content

Remove the typeck MIR pass #60422

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom
Closed
matthewjasper opened this issue Apr 30, 2019 · 0 comments · Fixed by #60516
Closed

Remove the typeck MIR pass #60422

matthewjasper opened this issue Apr 30, 2019 · 0 comments · Fixed by #60516
Labels
A-NLL Area: Non-lexical lifetimes (NLL) C-cleanup Category: PRs that clean code up or issues documenting cleanup. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.

Comments

@matthewjasper
Copy link
Contributor

This is now always run as part of NLL, so the pass is unnecessary

  • Remove rustc_mir::borrow_check::nll::type_check::TypeckMir
  • Remove the Options from TypeChecker
  • Fix any fall out
@matthewjasper matthewjasper added C-cleanup Category: PRs that clean code up or issues documenting cleanup. A-NLL Area: Non-lexical lifetimes (NLL) labels Apr 30, 2019
@matthewjasper matthewjasper changed the title Reomve the typeck MIR pass Remove the typeck MIR pass Apr 30, 2019
@jonas-schievink jonas-schievink added the T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. label Apr 30, 2019
@JohnTitor JohnTitor mentioned this issue May 3, 2019
Merged
Centril added a commit to Centril/rust that referenced this issue May 4, 2019
@Centril
Rollup merge of rust-lang#60516 - JohnTitor:remove-typeck, r=matthewj…
3cfd39b 
…asper

Remove TypeckMir

Fixes rust-lang#60422

r? @matthewjasper
# for free to join this conversation on GitHub. Already have an account? # to comment
Assignees
No one assigned
Labels
A-NLL Area: Non-lexical lifetimes (NLL) C-cleanup Category: PRs that clean code up or issues documenting cleanup. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Remove TypeckMir JohnTitor/rust
2 participants
@jonas-schievink @matthewjasper