Skip to content

Reinstate edition-guide toolstate check #60929

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom
Closed
ehuss opened this issue May 17, 2019 · 6 comments · Fixed by #61110
Closed

Reinstate edition-guide toolstate check #60929

ehuss opened this issue May 17, 2019 · 6 comments · Fixed by #61110
Assignees
@pnkfelix
Labels
P-high High priority T-release Relevant to the release subteam, which will review and decide on the PR/issue.

Comments

@ehuss
Copy link
Contributor

ehuss commented May 17, 2019 •
edited
Loading

This is a tracking issue for reverting the change introduced in #60791 which disabled the toolstate check for the edition-guide.

It is currently blocked on #60459 which is causing a test failure in the edition-guide. I will reinstate the check as soon as that issue is fixed.

@Mark-Simulacrum has requested the labels t-release and I-nominated.
@Centril Centril added T-release Relevant to the release subteam, which will review and decide on the PR/issue. I-nominated labels May 17, 2019
@Mark-Simulacrum
Copy link
Member

Tags are so that we don't forget this, we should keep it nominated until it's fixed.

@pietroalbini
Copy link
Member

pietroalbini commented May 21, 2019 •
edited
Loading

The check was reinstated in PR 8d41958.

@ehuss
Copy link
Contributor Author

ehuss commented May 21, 2019

@pietroalbini I think you have the wrong issue? There were two things (rls and edition guide). The PR you noted just reverted the RLS change. The edition-guide was separate (and done in a different way). It's still blocked on #60459.

@pietroalbini
Copy link
Member

...oh, that's what happen when I read just half of the title 😅

@pietroalbini pietroalbini reopened this May 21, 2019
@pnkfelix
Copy link
Member

triage: P-high. Assigning to self. Will likewise triage #60459. Removing nominated tag.

@pnkfelix pnkfelix added the P-high High priority label May 23, 2019
@pnkfelix pnkfelix self-assigned this May 23, 2019
@pnkfelix
Copy link
Member

actually I'll leave nominated tag, since this is for a team other than T-compiler so I don't want to mess with their tags.

@ehuss ehuss mentioned this issue May 24, 2019
Merged
Centril added a commit to Centril/rust that referenced this issue May 24, 2019
@Centril
Rollup merge of rust-lang#61110 - ehuss:revert-edition-override, r=Ma…
5749c15 
…rk-Simulacrum

Revert edition-guide toolstate override

Closes rust-lang#60929
Centril added a commit to Centril/rust that referenced this issue May 24, 2019
@Centril
Rollup merge of rust-lang#61110 - ehuss:revert-edition-override, r=Ma…
6bcc256 
…rk-Simulacrum

Revert edition-guide toolstate override

Closes rust-lang#60929
Centril added a commit to Centril/rust that referenced this issue May 25, 2019
@Centril
Rollup merge of rust-lang#61110 - ehuss:revert-edition-override, r=Ma…
f8b3ebe 
…rk-Simulacrum

Revert edition-guide toolstate override

Closes rust-lang#60929
# for free to join this conversation on GitHub. Already have an account? # to comment
Assignees

@pnkfelix pnkfelix

Labels
P-high High priority T-release Relevant to the release subteam, which will review and decide on the PR/issue.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Revert edition-guide toolstate override ehuss/rust
5 participants
@ehuss @pnkfelix @Centril @pietroalbini @Mark-Simulacrum