Skip to content

extended=false results in tools=["src","rls","clippy"] to be completely ignored #61194

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Closed
ghost opened this issue May 25, 2019 · 0 comments · Fixed by #68127
Closed

extended=false results in tools=["src","rls","clippy"] to be completely ignored #61194

ghost opened this issue May 25, 2019 · 0 comments · Fixed by #68127
Labels
C-bug Category: This is a bug. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap)

Comments

@ghost
Copy link

ghost commented May 25, 2019

this isn't immediately obvious from config.toml.example text:

# Enable a build of the extended rust tool set which is not only the compiler
# but also tools such as Cargo. This will also produce "combined installers"
# which are used to install Rust and Cargo together. This is disabled by
# default.
#extended = false

# Installs chosen set of extended tools if enables. By default builds all.
# If chosen tool failed to build the installation fails.
#tools = ["cargo", "rls", "clippy", "rustfmt", "analysis", "src"]

eg.
extended This is disabled by default, so that means extended=false right?
tools By default builds all., so I can uncomment that line and remove those I don't want right? wrong, extended=false means none of those get build (though I can only confirm the tested ones aren't being build: clippy, rls, analysis) and thus they are ignored which means this is also false If chosen tool failed to build the installation fails.

iirc this actually used to work before, with extended=false and tools = [ "src", "rls" ] and I'd get rls installed!

I got owned by this since: #60534 (comment)

tested on

commit 315ab95a9c13cbb69ae8538fcd69b9f7b0c30f89 (HEAD -> master, origin/master, origin/HEAD)
Merge: 5245803120 19b5a10346
Date:   Sat May 25 04:10:07 2019 +0000

which with extended=true fails at building rls step(as it should), but when extended=false it doesn't fail and doesn't build/install rls either, when tools = [ "src", "rls", "clippy" ]

@jonas-schievink jonas-schievink added T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap) C-bug Category: This is a bug. labels May 25, 2019
@bors bors closed this as completed in 7da1dcc Jan 14, 2020
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
C-bug Category: This is a bug. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap)
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant