Skip to content

extended=false results in tools=["src","rls","clippy"] to be completely ignored #61194

Closed
@ghost

Description

this isn't immediately obvious from config.toml.example text:

# Enable a build of the extended rust tool set which is not only the compiler
# but also tools such as Cargo. This will also produce "combined installers"
# which are used to install Rust and Cargo together. This is disabled by
# default.
#extended = false

# Installs chosen set of extended tools if enables. By default builds all.
# If chosen tool failed to build the installation fails.
#tools = ["cargo", "rls", "clippy", "rustfmt", "analysis", "src"]

eg.
extended This is disabled by default, so that means extended=false right?
tools By default builds all., so I can uncomment that line and remove those I don't want right? wrong, extended=false means none of those get build (though I can only confirm the tested ones aren't being build: clippy, rls, analysis) and thus they are ignored which means this is also false If chosen tool failed to build the installation fails.

iirc this actually used to work before, with extended=false and tools = [ "src", "rls" ] and I'd get rls installed!

I got owned by this since: #60534 (comment)

tested on

commit 315ab95a9c13cbb69ae8538fcd69b9f7b0c30f89 (HEAD -> master, origin/master, origin/HEAD)
Merge: 5245803120 19b5a10346
Date:   Sat May 25 04:10:07 2019 +0000

which with extended=true fails at building rls step(as it should), but when extended=false it doesn't fail and doesn't build/install rls either, when tools = [ "src", "rls", "clippy" ]

Metadata

Metadata

Assignees

No one assigned

    Labels

    C-bugCategory: This is a bug.T-bootstrapRelevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap)

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions