Skip to content

annotate-snippet emitter: Make use of -Z ui-testing flag #61811

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom
Closed
phansch opened this issue Jun 13, 2019 · 2 comments · Fixed by #62985
Closed

annotate-snippet emitter: Make use of -Z ui-testing flag #61811

phansch opened this issue Jun 13, 2019 · 2 comments · Fixed by #62985
Assignees
@rustbot
Labels
A-diagnostics Area: Messages for errors, warnings, and lints E-help-wanted Call for participation: Help is requested to fix this issue.

Comments

@phansch
Copy link
Member

phansch commented Jun 13, 2019 •
edited by rustbot
Loading

Part of #59346

To support LL lines in the first column of UI test output, we have to make use of the -Z ui-testing flag and update the annotate-snippet library.

Relevant FIXME:

rust/src/librustc_errors/annotate_snippet_emitter_writer.rs

Lines 176 to 179 in 57a3300

// FIXME(#59346): This method is used via the public interface, but setting the `ui_testing`
// flag currently does not anonymize line numbers. We would have to add the `maybe_anonymized`
// method from `emitter.rs` and implement rust-lang/annotate-snippets-rs#2 in order to
// anonymize line numbers.

  • The relevant PR in the annotate-snippet library has been merged and a new
    version needs to be released. Once that's done, we have to pass
    self.ui_testing as a second argument to DisplayListFormatter::new.

This issue has been assigned to @phansch via this comment.
@phansch

This comment has been minimized.

# to view
@rustbot rustbot added A-diagnostics Area: Messages for errors, warnings, and lints E-help-wanted Call for participation: Help is requested to fix this issue. labels Jun 13, 2019
@phansch
Copy link
Member Author

phansch commented Jun 13, 2019

@rustbot claim

@rustbot rustbot self-assigned this Jun 13, 2019
phansch added a commit to phansch/rust that referenced this issue Jul 25, 2019
@phansch
librustc_errors: Support ui-testing flag in annotate-snippet emitter
dd0f2ac 
This adds support for the `-Z ui-testing` flag to the new
annotate-snippet diagnostic emitter.

The support for the flag was added to `annotate-snippet-rs` in these PRs:

* rust-lang/annotate-snippets-rs#3
* rust-lang/annotate-snippets-rs#5

Closes rust-lang#61811
@phansch phansch mentioned this issue Jul 25, 2019
Merged
Centril added a commit to Centril/rust that referenced this issue Jul 26, 2019
@Centril
Rollup merge of rust-lang#62985 - phansch:support_ui_testing_flag, r=…
5492622 
…estebank

librustc_errors: Support ui-testing flag in annotate-snippet emitter

This adds support for the `-Z ui-testing` flag to the new
annotate-snippet diagnostic emitter.

Support for the flag was added to `annotate-snippet-rs` in these PRs:

* rust-lang/annotate-snippets-rs#3
* rust-lang/annotate-snippets-rs#5

r? @estebank

Closes rust-lang#61811
Centril added a commit to Centril/rust that referenced this issue Jul 26, 2019
@Centril
Rollup merge of rust-lang#62985 - phansch:support_ui_testing_flag, r=…
bc897a5 
…estebank

librustc_errors: Support ui-testing flag in annotate-snippet emitter

This adds support for the `-Z ui-testing` flag to the new
annotate-snippet diagnostic emitter.

Support for the flag was added to `annotate-snippet-rs` in these PRs:

* rust-lang/annotate-snippets-rs#3
* rust-lang/annotate-snippets-rs#5

r? @estebank

Closes rust-lang#61811
Centril added a commit to Centril/rust that referenced this issue Jul 26, 2019
@Centril
Rollup merge of rust-lang#62985 - phansch:support_ui_testing_flag, r=…
571a965 
…estebank

librustc_errors: Support ui-testing flag in annotate-snippet emitter

This adds support for the `-Z ui-testing` flag to the new
annotate-snippet diagnostic emitter.

Support for the flag was added to `annotate-snippet-rs` in these PRs:

* rust-lang/annotate-snippets-rs#3
* rust-lang/annotate-snippets-rs#5

r? @estebank

Closes rust-lang#61811
# for free to join this conversation on GitHub. Already have an account? # to comment
Assignees

@rustbot rustbot

Labels
A-diagnostics Area: Messages for errors, warnings, and lints E-help-wanted Call for participation: Help is requested to fix this issue.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

librustc_errors: Support ui-testing flag in annotate-snippet emitter phansch/rust
2 participants
@phansch @rustbot