Skip to content

Group all ABI tests. #62401

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom
Closed
eddyb opened this issue Jul 5, 2019 · 4 comments · Fixed by #62593
Closed

Group all ABI tests. #62401

eddyb opened this issue Jul 5, 2019 · 4 comments · Fixed by #62593
Assignees
@rustbot
Labels
A-testsuite Area: The testsuite used to check the correctness of rustc C-cleanup Category: PRs that clean code up or issues documenting cleanup. E-easy Call for participation: Easy difficulty. Experience needed to fix: Not much. Good first issue. E-mentor Call for participation: This issue has a mentor. Use #t-compiler/help on Zulip for discussion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.

Comments

@eddyb
Copy link
Member

eddyb commented Jul 5, 2019 •
edited by rustbot
Loading

There are a bunch of run-pass tests that should be in run-pass/abi (or some other directory if anyone has a better suggestion), and many of them are mentioned here:

rust/src/test/run-pass/abi-sysv64-arg-passing.rs

Lines 7 to 23 in baab191

// cabi-int-widening
// extern-pass-char
// extern-pass-u32
// extern-pass-u64
// extern-pass-double
// extern-pass-empty
// extern-pass-TwoU8s
// extern-pass-TwoU16s
// extern-pass-TwoU32s
// extern-pass-TwoU64s
// extern-return-TwoU8s
// extern-return-TwoU16s
// extern-return-TwoU32s
// extern-return-TwoU64s
// foreign-fn-with-byval
// issue-28676
// struct-return

You can also look for tests that mention rust_test_helpers - most of the functions from that C library are used to test ABIs.

cc @nagisa @rkruppe

This issue has been assigned to @kper via this comment.
@Centril Centril added C-cleanup Category: PRs that clean code up or issues documenting cleanup. E-easy Call for participation: Easy difficulty. Experience needed to fix: Not much. Good first issue. E-mentor Call for participation: This issue has a mentor. Use #t-compiler/help on Zulip for discussion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. A-testsuite Area: The testsuite used to check the correctness of rustc labels Jul 5, 2019
@Centril Centril mentioned this issue Jul 5, 2019
Merged
@kper
Copy link
Contributor

kper commented Jul 9, 2019

@rustbot claim

@rustbot rustbot self-assigned this Jul 9, 2019
@kper
Copy link
Contributor

kper commented Jul 9, 2019 •
edited
Loading

Is there a way to test if it's still working?

@eddyb
Copy link
Member Author

eddyb commented Jul 10, 2019

@kper look at the number of tests reported by ./x.py test --stage 1 src/test/run-pass.
They should be identical before and after the move.

@kper kper mentioned this issue Jul 11, 2019
Merged
@kper
Copy link
Contributor

kper commented Jul 11, 2019

@eddyb ok, the results look good. Can you check?

Centril added a commit to Centril/rust that referenced this issue Aug 15, 2019
@Centril
Rollup merge of rust-lang#62593 - kper:cleanup_abi, r=Centril
aa3f542 
Group all ABI tests.

r? @eddyb

Closes rust-lang#62401
Centril added a commit to Centril/rust that referenced this issue Aug 16, 2019
@Centril
Rollup merge of rust-lang#62593 - kper:cleanup_abi, r=Centril
100a02a 
Group all ABI tests.

r? @eddyb

Closes rust-lang#62401
# for free to join this conversation on GitHub. Already have an account? # to comment
Assignees

@rustbot rustbot

Labels
A-testsuite Area: The testsuite used to check the correctness of rustc C-cleanup Category: PRs that clean code up or issues documenting cleanup. E-easy Call for participation: Easy difficulty. Experience needed to fix: Not much. Good first issue. E-mentor Call for participation: This issue has a mentor. Use #t-compiler/help on Zulip for discussion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Group all ABI tests.
4 participants
@eddyb @Centril @kper @rustbot