Skip to content

rls no longer builds after rust-lang/rust#62679 #62803

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom
Closed
rust-highfive opened this issue Jul 19, 2019 · 0 comments · Fixed by #62805
Closed

rls no longer builds after rust-lang/rust#62679 #62803

rust-highfive opened this issue Jul 19, 2019 · 0 comments · Fixed by #62805
Assignees
@Xanewok
Labels
P-high High priority T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.

Comments

@rust-highfive
Copy link
Contributor

Hello, this is your friendly neighborhood mergebot.
After merging PR #62679, I observed that the tool rls no longer builds.
A follow-up PR to the repository https://github.com/rust-lang/rls is needed to fix the fallout.

cc @Xanewok, do you think you would have time to do the follow-up work?
If so, that would be great!

cc @Zoxc, the PR reviewer, and @rust-lang/compiler -- nominating for prioritization.
@rust-highfive rust-highfive added I-nominated T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Jul 19, 2019
@Xanewok Xanewok mentioned this issue Jul 20, 2019
Merged
bors added a commit that referenced this issue Jul 23, 2019
@bors
Auto merge of #62805 - Xanewok:update-rls, r=Xanewok
47de56c 
Update RLS

Supersedes #62537.
Closes #62803.

Fixes fallout after #62679.

r? @ghost
bors added a commit that referenced this issue Jul 23, 2019
@bors
Auto merge of #62805 - Xanewok:update-rls, r=Xanewok
44c1f97 
Update RLS

Supersedes #62537.
Closes #62803.

Fixes fallout after #62679.

r? @ghost
@nikomatsakis nikomatsakis added P-high High priority and removed I-nominated labels Jul 25, 2019
Centril added a commit to Centril/rust that referenced this issue Jul 30, 2019
@Centril
Rollup merge of rust-lang#62805 - Xanewok:update-rls, r=Xanewok
14eddad 
Update RLS and Rustfmt

Supersedes rust-lang#62537.
Closes rust-lang#62803.

Fixes fallout after rust-lang#62679.

r? @ghost
bors added a commit that referenced this issue Jul 30, 2019
@bors
Auto merge of #62805 - Xanewok:update-rls, r=Xanewok
e2eb571 
Update RLS and Rustfmt

Supersedes #62537.
Closes #62803.

Fixes fallout after #62679.

r? @ghost
bors added a commit that referenced this issue Jul 30, 2019
@bors
Auto merge of #62805 - Xanewok:update-rls, r=Xanewok
dddb7fc 
Update RLS and Rustfmt

Supersedes #62537.
Closes #62803.

Fixes fallout after #62679.

r? @ghost
# for free to join this conversation on GitHub. Already have an account? # to comment
Assignees

@Xanewok Xanewok

Labels
P-high High priority T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Update RLS and Rustfmt Xanewok/rust
3 participants
@nikomatsakis @Xanewok @rust-highfive