Skip to content

replace uses of list-ref-append list building with Queue.add #63

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Closed
graydon opened this issue Jun 24, 2010 · 1 comment
Closed

replace uses of list-ref-append list building with Queue.add #63

graydon opened this issue Jun 24, 2010 · 1 comment
Labels
C-cleanup Category: PRs that clean code up or issues documenting cleanup. E-easy Call for participation: Easy difficulty. Experience needed to fix: Not much. Good first issue.

Comments

@graydon
Copy link
Contributor

graydon commented Jun 24, 2010

I had overlooked the Queue module at first while writing; there are a bunch of residual uses of using a list ref and repeatedly building it. Queues are nicer.

@pcwalton
Copy link
Contributor

[pwalton@fireferret ~/Source/rust/src] grep -R "list ref" boot
[pwalton@fireferret ~/Source/rust/src] 

Closing.

pcwalton added a commit to pcwalton/rust that referenced this issue Sep 25, 2014
This makes `FnMut` require `FnOnce` and `Fn` require `FnMut`. Therefore,
this change breaks code that implements the `FnMut` and/or `Fn` traits
directly, without also implementing their dependencies. A simple
forwarding implementation that defines `FnOnce` in terms of `FnMut`
and/or `Fn` in terms of `FnMut` will suffice.

This does not affect code that simply uses the `|&:|`/`|&mut:|`/`|:|`
unboxed closure construction notation.

Part of RFC rust-lang#44; needed to implement RFC rust-lang#63.

Part of issue rust-lang#12831.

[breaking-change]
pcwalton added a commit to pcwalton/rust that referenced this issue Sep 26, 2014
in favor of `move`.

This breaks code that used `move` as an identifier, because it is now a
keyword. Change such identifiers to not use the keyword `move`.
Additionally, this breaks code that was counting on by-value or
by-reference capture semantics for unboxed closures (behind the feature
gate). Change `ref |:|` to `|:|` and `|:|` to `move |:|`.

Part of RFC rust-lang#63; part of issue rust-lang#12831.

[breaking-change]
arielb1 pushed a commit to arielb1/rust that referenced this issue Apr 10, 2015
oli-obk added a commit to oli-obk/rust that referenced this issue Jul 19, 2017
keeperofdakeys pushed a commit to keeperofdakeys/rust that referenced this issue Dec 12, 2017
dlrobertson pushed a commit to dlrobertson/rust that referenced this issue Nov 29, 2018
eddyb pushed a commit to eddyb/rust that referenced this issue Jun 30, 2020
As requested in rust-lang#63, this adds a way to list all items in the type
namespace of a crate.
Aaron1011 pushed a commit to Aaron1011/rust that referenced this issue Oct 26, 2020
djtech-dev pushed a commit to djtech-dev/rust that referenced this issue Dec 9, 2021
zhassan-aws added a commit to jaisnan/rust-dev that referenced this issue Aug 22, 2024
By submitting this pull request, I confirm that my contribution is made
under the terms of the Apache 2.0 and MIT licenses.
This issue was closed.
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
C-cleanup Category: PRs that clean code up or issues documenting cleanup. E-easy Call for participation: Easy difficulty. Experience needed to fix: Not much. Good first issue.
Projects
None yet
Development

No branches or pull requests

2 participants