Skip to content

cleanup: remove needless reference to Instance #63409

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom
Closed
Mark-Simulacrum opened this issue Aug 9, 2019 · 0 comments · Fixed by #63464
Closed

cleanup: remove needless reference to Instance #63409

Mark-Simulacrum opened this issue Aug 9, 2019 · 0 comments · Fixed by #63464
Assignees
@Mark-Simulacrum
Labels
A-const-eval Area: Constant evaluation, covers all const contexts (static, const fn, ...) C-cleanup Category: PRs that clean code up or issues documenting cleanup. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.

Comments

@Mark-Simulacrum
Copy link
Member

Mark-Simulacrum commented Aug 9, 2019 •
edited
Loading

At least one case of this is in src/librustc_mir/interpret/snapshot.rs on line 305, but grepping is also advisable.

Originally posted by @eddyb in #63287
@jonas-schievink jonas-schievink added A-const-eval Area: Constant evaluation, covers all const contexts (static, const fn, ...) C-cleanup Category: PRs that clean code up or issues documenting cleanup. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Aug 9, 2019
@Mark-Simulacrum Mark-Simulacrum self-assigned this Aug 11, 2019
@Mark-Simulacrum Mark-Simulacrum mentioned this issue Aug 11, 2019
Merged
Mark-Simulacrum added a commit to Mark-Simulacrum/rust that referenced this issue Aug 11, 2019
@Mark-Simulacrum
Rollup merge of rust-lang#63464 - Mark-Simulacrum:deref-instance, r=e…
4229dc3 
…ddyb

Copy ty::Instance instead of passing by reference

ty::Instance is small and Copy, we should not be adding additional
indirection.

Fixes rust-lang#63409.

r? @eddyb
# for free to join this conversation on GitHub. Already have an account? # to comment
Assignees

@Mark-Simulacrum Mark-Simulacrum

Labels
A-const-eval Area: Constant evaluation, covers all const contexts (static, const fn, ...) C-cleanup Category: PRs that clean code up or issues documenting cleanup. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Copy ty::Instance instead of passing by reference Mark-Simulacrum/rust
2 participants
@jonas-schievink @Mark-Simulacrum