Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

./x.py build --help gives misleading help #63928

Closed
jsgf opened this issue Aug 26, 2019 · 3 comments · Fixed by #63949
Closed

./x.py build --help gives misleading help #63928

jsgf opened this issue Aug 26, 2019 · 3 comments · Fixed by #63949
Labels
C-bug Category: This is a bug. E-easy Call for participation: Easy difficulty. Experience needed to fix: Not much. Good first issue. E-mentor Call for participation: This issue has a mentor. Use #t-compiler/help on Zulip for discussion. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap)

Comments

@jsgf
Copy link
Contributor

jsgf commented Aug 26, 2019

$ ./x.py build --help
[...]
    For a quick build of a usable compiler, you can pass:

        ./x.py build --stage 1 src/libtest

But in practice:

$ ./x.py build --stage 1 src/libtest
Updating only changed submodules
Submodules updated in 0.13 seconds
    Finished dev [unoptimized] target(s) in 0.15s
thread 'main' panicked at 'Error: no rules matched src/libtest.', src/bootstrap/builder.rs:231:21
note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace.
failed to run: /data/users/jsgf/third-party2/rust/build/bootstrap/debug/bootstrap build --stage 1 src/libtest
Build completed unsuccessfully in 0:00:01

Should this still work, or is the help message wrong?

@jonas-schievink jonas-schievink added T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap) C-bug Category: This is a bug. labels Aug 26, 2019
@mati865
Copy link
Contributor

mati865 commented Aug 27, 2019

I think it stopped working after #63637 and the message should be updated.

@JohnTitor
Copy link
Member

Should be ./x.py build --stage 1 src/libstd?

@Mark-Simulacrum
Copy link
Member

We should probably change all_krates("std") to all_krates("test")` in a few places -- notably here

run.all_krates("std")
and in a similar place in check.rs

@Mark-Simulacrum Mark-Simulacrum added E-easy Call for participation: Easy difficulty. Experience needed to fix: Not much. Good first issue. E-mentor Call for participation: This issue has a mentor. Use #t-compiler/help on Zulip for discussion. labels Aug 27, 2019
Centril added a commit to Centril/rust that referenced this issue Aug 29, 2019
Centril added a commit to Centril/rust that referenced this issue Aug 29, 2019
@bors bors closed this as completed in 808722e Aug 29, 2019
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
C-bug Category: This is a bug. E-easy Call for participation: Easy difficulty. Experience needed to fix: Not much. Good first issue. E-mentor Call for participation: This issue has a mentor. Use #t-compiler/help on Zulip for discussion. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap)
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants