Skip to content

miri no longer builds after rust-lang/rust#64354 #64363

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom
Closed
rust-highfive opened this issue Sep 10, 2019 · 1 comment · Fixed by #64485
Closed

miri no longer builds after rust-lang/rust#64354 #64363

rust-highfive opened this issue Sep 10, 2019 · 1 comment · Fixed by #64485
Assignees
@eddyb @RalfJung @oli-obk
Labels
P-medium Medium priority T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.

Comments

@rust-highfive
Copy link
Contributor

Hello, this is your friendly neighborhood mergebot.
After merging PR #64354, I observed that the tool miri has failing tests.
A follow-up PR to the repository https://github.com/rust-lang/miri is needed to fix the fallout.

cc @Centril, do you think you would have time to do the follow-up work?
If so, that would be great!

cc @Centril, the PR reviewer, and @rust-lang/compiler -- nominating for prioritization.
@rust-highfive rust-highfive added I-nominated T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Sep 10, 2019
@pnkfelix pnkfelix added P-medium Medium priority and removed I-nominated labels Sep 12, 2019
@pnkfelix
Copy link
Member

triage: P-medium. Unnominating.

This was referenced Sep 13, 2019
Closed
Merged
Centril added a commit to Centril/rust that referenced this issue Sep 16, 2019
@Centril
Rollup merge of rust-lang#64485 - RalfJung:miri, r=alexcrichton
3ddb3ba 
update Miri

Fixes rust-lang#64363

r? @alexcrichton for the Cargo.toml changes: with byteorder 1.3, the `i128` feature is a NOP, so we can remove it everywhere and then get rid of this crate in the workspace-hack.
@bors bors closed this as completed in a31d71f Sep 17, 2019
# for free to join this conversation on GitHub. Already have an account? # to comment
Assignees

@eddyb eddyb

@RalfJung RalfJung

@oli-obk oli-obk

Labels
P-medium Medium priority T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

update Miri RalfJung/rust
5 participants
@eddyb @pnkfelix @RalfJung @oli-obk @rust-highfive