-
Notifications
You must be signed in to change notification settings - Fork 13.4k
re_rebalance_coherence
doesn't properly account for fundamental types
#64412
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
Labels
A-trait-system
Area: Trait system
C-bug
Category: This is a bug.
F-re_rebalance_coherence
`#![feature(re_rebalance_coherence)]`
I-unsound
Issue: A soundness hole (worst kind of bug), see: https://en.wikipedia.org/wiki/Soundness
requires-nightly
This issue requires a nightly compiler in some way.
T-compiler
Relevant to the compiler team, which will review and decide on the PR/issue.
Comments
This was referenced Sep 12, 2019
Centril
added a commit
to Centril/rust
that referenced
this issue
Sep 20, 2019
…e-tests, r=nikomatsakis Bugfix/rfc 2451 rerebalance tests r? @nikomatsakis Fixes rust-lang#64412 Depends/Contains on rust-lang#64414 cc rust-lang#55437 and rust-lang#63599
tmandry
added a commit
to tmandry/rust
that referenced
this issue
Sep 20, 2019
…e-tests, r=nikomatsakis Bugfix/rfc 2451 rerebalance tests r? @nikomatsakis Fixes rust-lang#64412 Depends/Contains on rust-lang#64414 cc rust-lang#55437 and rust-lang#63599
tmandry
added a commit
to tmandry/rust
that referenced
this issue
Sep 20, 2019
…e-tests, r=nikomatsakis Bugfix/rfc 2451 rerebalance tests r? @nikomatsakis Fixes rust-lang#64412 Depends/Contains on rust-lang#64414 cc rust-lang#55437 and rust-lang#63599
tmandry
added a commit
to tmandry/rust
that referenced
this issue
Sep 20, 2019
…e-tests, r=nikomatsakis Bugfix/rfc 2451 rerebalance tests r? @nikomatsakis Fixes rust-lang#64412 Depends/Contains on rust-lang#64414 cc rust-lang#55437 and rust-lang#63599
tmandry
added a commit
to tmandry/rust
that referenced
this issue
Sep 20, 2019
…e-tests, r=nikomatsakis Bugfix/rfc 2451 rerebalance tests r? @nikomatsakis Fixes rust-lang#64412 Depends/Contains on rust-lang#64414 cc rust-lang#55437 and rust-lang#63599
tmandry
added a commit
to tmandry/rust
that referenced
this issue
Sep 21, 2019
…e-tests, r=nikomatsakis Bugfix/rfc 2451 rerebalance tests r? @nikomatsakis Fixes rust-lang#64412 Depends/Contains on rust-lang#64414 cc rust-lang#55437 and rust-lang#63599
Centril
added a commit
to Centril/rust
that referenced
this issue
Sep 22, 2019
…e-tests, r=nikomatsakis Bugfix/rfc 2451 rerebalance tests r? @nikomatsakis Fixes rust-lang#64412 Depends/Contains on rust-lang#64414 cc rust-lang#55437 and rust-lang#63599
Centril
added a commit
to Centril/rust
that referenced
this issue
Sep 24, 2019
…e-tests, r=nikomatsakis Bugfix/rfc 2451 rerebalance tests r? @nikomatsakis Fixes rust-lang#64412 Depends/Contains on rust-lang#64414 cc rust-lang#55437 and rust-lang#63599
Centril
added a commit
to Centril/rust
that referenced
this issue
Sep 27, 2019
…e-tests, r=nikomatsakis Bugfix/rfc 2451 rerebalance tests r? @nikomatsakis Fixes rust-lang#64412 Depends/Contains on rust-lang#64414 cc rust-lang#55437 and rust-lang#63599
Centril
added a commit
to Centril/rust
that referenced
this issue
Sep 28, 2019
…e-tests, r=nikomatsakis Bugfix/rfc 2451 rerebalance tests r? @nikomatsakis Fixes rust-lang#64412 Depends/Contains on rust-lang#64414 cc rust-lang#55437 and rust-lang#63599
Centril
added a commit
to Centril/rust
that referenced
this issue
Sep 28, 2019
…e-tests, r=nikomatsakis Bugfix/rfc 2451 rerebalance tests r? @nikomatsakis Fixes rust-lang#64412 Depends/Contains on rust-lang#64414 cc rust-lang#55437 and rust-lang#63599
bors
added a commit
that referenced
this issue
Sep 29, 2019
…nikomatsakis Bugfix/rfc 2451 rerebalance tests r? @nikomatsakis Fixes #64412 Depends/Contains on #64414 cc #55437 and #63599
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Labels
A-trait-system
Area: Trait system
C-bug
Category: This is a bug.
F-re_rebalance_coherence
`#![feature(re_rebalance_coherence)]`
I-unsound
Issue: A soundness hole (worst kind of bug), see: https://en.wikipedia.org/wiki/Soundness
requires-nightly
This issue requires a nightly compiler in some way.
T-compiler
Relevant to the compiler team, which will review and decide on the PR/issue.
As part of an effort to stabilize the
re_rebalance_coherence
RFC (#63599), I was creating tests trying to get more coverage of all possible scenarios, and I found that we don't seem to be handling fundamental types in the way that the RFC specifies.In particular this test is presently accepted and yet ought to be rejected:
I'll be adding this test (along with some others) in a PR soon with "FIXME" comments.
The text was updated successfully, but these errors were encountered: