-
Notifications
You must be signed in to change notification settings - Fork 13.3k
Suggested fix does not account for operator precedence #64919
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
Labels
A-suggestion-diagnostics
Area: Suggestions generated by the compiler applied by `cargo fix`
C-bug
Category: This is a bug.
E-easy
Call for participation: Easy difficulty. Experience needed to fix: Not much. Good first issue.
T-compiler
Relevant to the compiler team, which will review and decide on the PR/issue.
Comments
I would like to pick this up, in case nobody is working on it |
@sam09: go ahead! |
tmandry
added a commit
to tmandry/rust
that referenced
this issue
Oct 1, 2019
Fixes rust-lang#64919. Suggest fix based on operator precendence. Fixes rust-lang#64919
tmandry
added a commit
to tmandry/rust
that referenced
this issue
Oct 1, 2019
Fixes rust-lang#64919. Suggest fix based on operator precendence. Fixes rust-lang#64919
Centril
added a commit
to Centril/rust
that referenced
this issue
Oct 1, 2019
Fixes rust-lang#64919. Suggest fix based on operator precendence. Fixes rust-lang#64919
Centril
added a commit
to Centril/rust
that referenced
this issue
Oct 1, 2019
Fixes rust-lang#64919. Suggest fix based on operator precendence. Fixes rust-lang#64919
bors
added a commit
that referenced
this issue
Oct 1, 2019
Rollup of 7 pull requests Successful merges: - #63416 (apfloat: improve doc comments) - #64820 (BTreeSet intersection, is_subset & difference optimizations) - #64910 (syntax: cleanup param, method, and misc parsing) - #64912 (Remove unneeded `fn main` blocks from docs) - #64933 (Fixes #64919. Suggest fix based on operator precendence.) - #64943 (Add lower bound doctests for `saturating_{add,sub}` signed ints) - #64950 (Simplify interners) Failed merges: r? @ghost
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Labels
A-suggestion-diagnostics
Area: Suggestions generated by the compiler applied by `cargo fix`
C-bug
Category: This is a bug.
E-easy
Call for participation: Easy difficulty. Experience needed to fix: Not much. Good first issue.
T-compiler
Relevant to the compiler team, which will review and decide on the PR/issue.
This fails (as expected):
However, the help message is wrong:
It should suggest
(1 + 2).to_string()
instead.Rust version: 1.38.0 (stable)
The text was updated successfully, but these errors were encountered: