Skip to content

tidy should skip RLS files #64957

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom
Closed
spastorino opened this issue Oct 1, 2019 · 4 comments · Fixed by #64998
Closed

tidy should skip RLS files #64957

spastorino opened this issue Oct 1, 2019 · 4 comments · Fixed by #64998
Labels
T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap) T-infra Relevant to the infrastructure team, which will review and decide on the PR/issue.

Comments

@spastorino
Copy link
Member

spastorino commented Oct 1, 2019 •
edited
Loading

tidy should skip RLS files or even more, it should probably skip untracked files.

[santiago@galago rust1 (make-place-builder)]$ ./x.py test -i --stage 1 --keep-stage 1 src/tools/tidy
Updating only changed submodules
Submodules updated in 0.02 seconds
    Finished dev [unoptimized] target(s) in 0.12s
Building stage0 tool tidy (x86_64-unknown-linux-gnu)
    Finished release [optimized + debuginfo] target(s) in 0.12s
tidy check
tidy error: /home/santiago/src/oss/rust1/src/librustc_mir/target/rls/debug/build/backtrace-sys-f1076cfdc06a1d7a/out/backtrace-supported.h: empty file
tidy error: /home/santiago/src/oss/rust1/src/librustc_mir/target/rls/debug/build/backtrace-sys-f1076cfdc06a1d7a/out/backtrace-supported.h: leading newline
tidy error: /home/santiago/src/oss/rust1/src/librustc_mir/target/rls/debug/build/backtrace-sys-f1076cfdc06a1d7a/out/config.h: empty file
tidy error: /home/santiago/src/oss/rust1/src/librustc_mir/target/rls/debug/build/backtrace-sys-f1076cfdc06a1d7a/out/config.h: leading newline
tidy error: /home/santiago/src/oss/rust1/src/librustc_mir/target/rls/debug/build/backtrace-sys-3648bfa24214c6f1/out/backtrace-supported.h: empty file
tidy error: /home/santiago/src/oss/rust1/src/librustc_mir/target/rls/debug/build/backtrace-sys-3648bfa24214c6f1/out/backtrace-supported.h: leading newline
tidy error: /home/santiago/src/oss/rust1/src/librustc_mir/target/rls/debug/build/backtrace-sys-3648bfa24214c6f1/out/config.h: empty file
tidy error: /home/santiago/src/oss/rust1/src/librustc_mir/target/rls/debug/build/backtrace-sys-3648bfa24214c6f1/out/config.h: leading newline
tidy error: /home/santiago/src/oss/rust1/src/librustc/target/rls/debug/build/backtrace-sys-f1076cfdc06a1d7a/out/backtrace-supported.h: empty file
tidy error: /home/santiago/src/oss/rust1/src/librustc/target/rls/debug/build/backtrace-sys-f1076cfdc06a1d7a/out/backtrace-supported.h: leading newline
tidy error: /home/santiago/src/oss/rust1/src/librustc/target/rls/debug/build/backtrace-sys-f1076cfdc06a1d7a/out/config.h: empty file
tidy error: /home/santiago/src/oss/rust1/src/librustc/target/rls/debug/build/backtrace-sys-f1076cfdc06a1d7a/out/config.h: leading newline
tidy error: /home/santiago/src/oss/rust1/src/librustc/target/rls/debug/build/backtrace-sys-3648bfa24214c6f1/out/backtrace-supported.h: empty file
tidy error: /home/santiago/src/oss/rust1/src/librustc/target/rls/debug/build/backtrace-sys-3648bfa24214c6f1/out/backtrace-supported.h: leading newline
tidy error: /home/santiago/src/oss/rust1/src/librustc/target/rls/debug/build/backtrace-sys-3648bfa24214c6f1/out/config.h: empty file
tidy error: /home/santiago/src/oss/rust1/src/librustc/target/rls/debug/build/backtrace-sys-3648bfa24214c6f1/out/config.h: leading newline
tidy error: /home/santiago/src/oss/rust1/src/librustc/target/rls/debug/build/backtrace-sys-803a19e316a7f5c0/out/backtrace-supported.h: empty file
tidy error: /home/santiago/src/oss/rust1/src/librustc/target/rls/debug/build/backtrace-sys-803a19e316a7f5c0/out/backtrace-supported.h: leading newline
tidy error: /home/santiago/src/oss/rust1/src/librustc/target/rls/debug/build/backtrace-sys-803a19e316a7f5c0/out/config.h: empty file
tidy error: /home/santiago/src/oss/rust1/src/librustc/target/rls/debug/build/backtrace-sys-803a19e316a7f5c0/out/config.h: leading newline
some tidy checks failed
@csmoe csmoe added T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap) T-infra Relevant to the infrastructure team, which will review and decide on the PR/issue. labels Oct 1, 2019
@euclio
Copy link
Contributor

euclio commented Oct 1, 2019 •
edited
Loading

This is a regression; it was originally reported at #52158 and fixed in #55213.

@Mark-Simulacrum
Copy link
Member

Hm so to be clear it is currently broken but was previously already fixed?

We probably just need to re-add target to the filter_dirs list here.

@spastorino
Copy link
Member Author

This was changed in this commit by @petrochenkov. I guess there may be good reasons to remove all these directories, I'd say that we need to skip things that are listed on .gitignore :).

@petrochenkov
Copy link
Contributor

petrochenkov commented Oct 2, 2019 •
edited
Loading

I assumed target was only created next to the top level Cargo.toml so it could not be visited by tidy anyway.
If that's not the case, please feel free to re-add it (with a comment, if possible).

@spastorino spastorino mentioned this issue Oct 2, 2019
Merged
Manishearth added a commit to Manishearth/rust that referenced this issue Oct 2, 2019
@Manishearth
Rollup merge of rust-lang#64998 - spastorino:filter-rls-on-tidy, r=pe…
2cb64f2 
…trochenkov

Filter out RLS output directories on tidy runs

Closes rust-lang#64957

r? @petrochenkov
Centril added a commit to Centril/rust that referenced this issue Oct 2, 2019
@Centril
Rollup merge of rust-lang#64998 - spastorino:filter-rls-on-tidy, r=pe…
f6125f1 
…trochenkov

Filter out RLS output directories on tidy runs

Closes rust-lang#64957

r? @petrochenkov
@bors bors closed this as completed in 4ea2be7 Oct 3, 2019
# for free to join this conversation on GitHub. Already have an account? # to comment
Assignees
No one assigned
Labels
T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap) T-infra Relevant to the infrastructure team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Filter out RLS output directories on tidy runs spastorino/rust
5 participants
@spastorino @euclio @Mark-Simulacrum @petrochenkov @csmoe