Skip to content

Cleanup: Deduplicate implementations of is_{freeze,copy,sized}_raw #65259

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom
Closed
Centril opened this issue Oct 10, 2019 · 2 comments · Fixed by #65263
Closed

Cleanup: Deduplicate implementations of is_{freeze,copy,sized}_raw #65259

Centril opened this issue Oct 10, 2019 · 2 comments · Fixed by #65263
Assignees
@rustbot
Labels
C-cleanup Category: PRs that clean code up or issues documenting cleanup. E-easy Call for participation: Easy difficulty. Experience needed to fix: Not much. Good first issue. E-help-wanted Call for participation: Help is requested to fix this issue. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.

Comments

@Centril
Copy link
Contributor

Centril commented Oct 10, 2019 •
edited by rustbot
Loading

See: https://doc.rust-lang.org/nightly/nightly-rustc/src/rustc/ty/util.rs.html#1045

This issue has been assigned to @mbStavola via this comment.
@Centril Centril added E-easy Call for participation: Easy difficulty. Experience needed to fix: Not much. Good first issue. C-cleanup Category: PRs that clean code up or issues documenting cleanup. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. E-help-wanted Call for participation: Help is requested to fix this issue. labels Oct 10, 2019
@mbStavola
Copy link
Contributor

I'm interested in taking this!

@Centril
Copy link
Contributor Author

Centril commented Oct 10, 2019

@rustbot assign @mbStavola

@rustbot rustbot self-assigned this Oct 10, 2019
@mbStavola mbStavola mentioned this issue Oct 10, 2019
Merged
tmandry added a commit to tmandry/rust that referenced this issue Oct 11, 2019
@tmandry
Rollup merge of rust-lang#65263 - mbStavola:dedup-raw-item-fns, r=Cen…
4e7633d 
…tril

Deduplicate is_{freeze,copy,sized}_raw

Addresses rust-lang#65259

Deduplicates `is_{freeze,copy,sized}_raw` by delegating to a new method which takes in a `LangItem`.
tmandry added a commit to tmandry/rust that referenced this issue Oct 11, 2019
@tmandry
Rollup merge of rust-lang#65263 - mbStavola:dedup-raw-item-fns, r=Cen…
f55e9b9 
…tril

Deduplicate is_{freeze,copy,sized}_raw

Addresses rust-lang#65259

Deduplicates `is_{freeze,copy,sized}_raw` by delegating to a new method which takes in a `LangItem`.
Centril added a commit to Centril/rust that referenced this issue Oct 11, 2019
@Centril
Rollup merge of rust-lang#65263 - mbStavola:dedup-raw-item-fns, r=Cen…
b8f7667 
…tril

Deduplicate is_{freeze,copy,sized}_raw

Addresses rust-lang#65259

Deduplicates `is_{freeze,copy,sized}_raw` by delegating to a new method which takes in a `LangItem`.
@bors bors closed this as completed in e4eb54d Oct 12, 2019
# for free to join this conversation on GitHub. Already have an account? # to comment
Assignees

@rustbot rustbot

Labels
C-cleanup Category: PRs that clean code up or issues documenting cleanup. E-easy Call for participation: Easy difficulty. Experience needed to fix: Not much. Good first issue. E-help-wanted Call for participation: Help is requested to fix this issue. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Deduplicate is_{freeze,copy,sized}_raw mbStavola/rust
3 participants
@mbStavola @Centril @rustbot