Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

non-empty glob statement regression 1.39 #65523

Closed
Mark-Simulacrum opened this issue Oct 17, 2019 · 7 comments
Closed

non-empty glob statement regression 1.39 #65523

Mark-Simulacrum opened this issue Oct 17, 2019 · 7 comments
Assignees
Labels
E-easy Call for participation: Easy difficulty. Experience needed to fix: Not much. Good first issue. E-mentor Call for participation: This issue has a mentor. Use #t-compiler/help on Zulip for discussion. E-needs-bisection Call for participation: This issue needs bisection: https://github.com/rust-lang/cargo-bisect-rustc E-needs-mcve Call for participation: This issue has a repro, but needs a Minimal Complete and Verifiable Example P-high High priority regression-from-stable-to-beta Performance or correctness regression from stable to beta. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.

Comments

@Mark-Simulacrum
Copy link
Member

Mark-Simulacrum commented Oct 17, 2019

https://crater-reports.s3.amazonaws.com/beta-1.39-1/beta-2019-09-28/reg/impl_ops-0.1.1/log.txt

cc #62334
cc @petrochenkov

cc #64962

This issue has been assigned to @XiangQingW via this comment.

@Mark-Simulacrum Mark-Simulacrum added T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. regression-from-stable-to-beta Performance or correctness regression from stable to beta. E-needs-bisection Call for participation: This issue needs bisection: https://github.com/rust-lang/cargo-bisect-rustc E-needs-mcve Call for participation: This issue has a repro, but needs a Minimal Complete and Verifiable Example labels Oct 17, 2019
@Mark-Simulacrum Mark-Simulacrum added this to the 1.39 milestone Oct 17, 2019
@petrochenkov petrochenkov self-assigned this Oct 17, 2019
@petrochenkov
Copy link
Contributor

Similarly to #65090 this is very likely a combination of the recent changes in expansion order (#63248, #63867) and globs not fetching macro expanded names properly (#56593).

In this case, however, the fix may be to turn the "non-empty glob must import something" error into a lint, we have an issue about that - #62334.

@petrochenkov petrochenkov added E-easy Call for participation: Easy difficulty. Experience needed to fix: Not much. Good first issue. E-mentor Call for participation: This issue has a mentor. Use #t-compiler/help on Zulip for discussion. labels Oct 17, 2019
@XiangQingW
Copy link
Contributor

@rustbot claim

@pnkfelix
Copy link
Member

triage: P-high

@pnkfelix pnkfelix added the P-high High priority label Oct 24, 2019
@nikomatsakis
Copy link
Contributor

Based on @petrochenkov's comment, it sounds like we plan to fix this in some form, and hence I am marking this as P-high.

I'm not clear though on who is going to fix this and how -- I'm going to re-assign @petrochenkov (as well as @XiangQingW) -- but perhaps somebody could clarify exactly which steps they plan to take? Sounds like maybe fixing #62334 is the plan?

@nikomatsakis nikomatsakis assigned rustbot and petrochenkov and unassigned rustbot Oct 24, 2019
@XiangQingW
Copy link
Contributor

I'll spend some time to dive into the issue this weekend.

@Centril
Copy link
Contributor

Centril commented Oct 24, 2019

This already has an outstanding PR in #65539.

@Centril Centril removed this from the 1.39 milestone Nov 7, 2019
@pnkfelix
Copy link
Member

pnkfelix commented Nov 7, 2019

closing as fixed by #65539

@pnkfelix pnkfelix closed this as completed Nov 7, 2019
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
E-easy Call for participation: Easy difficulty. Experience needed to fix: Not much. Good first issue. E-mentor Call for participation: This issue has a mentor. Use #t-compiler/help on Zulip for discussion. E-needs-bisection Call for participation: This issue needs bisection: https://github.com/rust-lang/cargo-bisect-rustc E-needs-mcve Call for participation: This issue has a repro, but needs a Minimal Complete and Verifiable Example P-high High priority regression-from-stable-to-beta Performance or correctness regression from stable to beta. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Development

No branches or pull requests

7 participants